Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 119343004: IndexedDB: Simplify data loss code/message routing (Closed)

Created:
7 years ago by jsbell
Modified:
7 years ago
Reviewers:
ericu, dgrogan
CC:
chromium-reviews, jsbell, jam, alecflett, joi+watch-content_chromium.org, darin-cc_chromium.org, cmumford, dgrogan
Visibility:
Public.

Description

IndexedDB: Simplify data loss code/message routing Rather than passing a code/message pair through the entire open call sequence, let the data loss status be assigned to the callbacks object which is already passed along. R=dgrogan BUG=329931 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242155

Patch Set 1 #

Patch Set 2 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -93 lines) Patch
M content/browser/indexed_db/indexed_db_callbacks.h View 3 chunks +9 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_callbacks.cc View 14 chunks +25 lines, -8 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database.h View 3 chunks +1 line, -19 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database.cc View 1 9 chunks +9 lines, -54 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jsbell
dgrogan@ - WDYT?
7 years ago (2013-12-19 18:16:30 UTC) #1
dgrogan
lgtm nice cleanup
7 years ago (2013-12-19 19:40:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/119343004/20001
7 years ago (2013-12-19 20:01:47 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=108232
7 years ago (2013-12-20 01:05:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/119343004/20001
7 years ago (2013-12-20 01:13:00 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=108401
7 years ago (2013-12-20 08:49:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/119343004/20001
7 years ago (2013-12-20 18:05:32 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-20 20:01:28 UTC) #8
Message was sent while issue was closed. 
Change committed as 242155

Powered by Google App Engine
This is Rietveld 408576698