Fast blurred rectangles on GPU

src/effects/SkBlurMask.h

 
 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #ifndef SkBlurMask_DEFINED
@@ skipping 44 matching lines @@
     static bool Blur(SkMask* dst, const SkMask& src,
                      SkScalar radius, Style style, Quality quality,
                      SkIPoint* margin = NULL);
 
     SK_ATTR_DEPRECATED("use sigma version")
     static bool BlurGroundTruth(SkMask* dst, const SkMask& src,
                                 SkScalar radius, Style style,
                                 SkIPoint* margin = NULL);
 
     static SkScalar ConvertRadiusToSigma(SkScalar radius);
+    
+    static uint8_t ProfileLookup(uint8_t *profile, int loc, int blurred_width, int sharp_width);

[reed1, 2014/01/02 17:32:39]

Can you add some dox for these?

One example for ComputeBlurProfile
- how was uint8_t allocated (so I can know how to free the memory)?
- how much was allocated, or do I not need to know?

For the scanline routine:
- what is profile_size? bytes (size_t), or count (int)
- can profile be const?
- why is sigma float here, but SkScalar in the previous function?

[humper, 2014/01/02 18:12:10]

Dox added, consts added, unnecessary profile_size argument removed from one of
the functions!

I believe that the reason the sigmas have different types is that ComputeProfile
is used both by the CPU and the GPU, while ComputeBlurredScanline got factored
out of the CPU so we could pass the scanlines down to the GPU, but it looks like
I didn't quite finish the refactor, so there was a little more to do there.  I
fixed it up.

+    static void ComputeBlurProfile(SkScalar sigma, uint8_t **profile_out);
+    static void ComputeBlurredScanline(uint8_t *pixels, uint8_t *profile, unsigned int profile_size, 
+                                       unsigned int width, float sigma);
+    
+    
+    
 };
 
 #endif