Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 119342: Use the new portable FTP implementation on non-Windows platforms.... (Closed)

Created:
11 years, 6 months ago by wtc
Modified:
9 years, 7 months ago
Reviewers:
dank, ibrar
CC:
chromium-reviews_googlegroups.com, Amanda Walker, pink (ping after 24hrs)
Visibility:
Public.

Description

Use the new portable FTP implementation on non-Windows platforms. Note: the new FTP is still work in progress. R=dank BUG=http://crbug.com/4965 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19037

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/url_request/url_request_job_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
wtc
playmobil: please review this CL. Do you think it is fine to use an incomplete ...
11 years, 6 months ago (2009-06-09 02:23:01 UTC) #1
wtc
Ibrar, I tested your FTP code only with ftp://ftp.mozilla.org/. When I clicked on the nspr-4.8.tar.gz ...
11 years, 6 months ago (2009-06-09 12:46:20 UTC) #2
wtc
Amanda, Mike, I just checked in Ibrar's fix for the FTP download issue (http://codereview.chromium.org/118459). I ...
11 years, 6 months ago (2009-06-09 21:54:36 UTC) #3
wtc
Dan, could you review this CL? It's time to turn on the new FTP code ...
11 years, 6 months ago (2009-06-19 15:01:57 UTC) #4
dank
It just hangs for me. For instance, ftp://ftp.gnu.org doesn't work. I don't feel comfortable turning ...
11 years, 6 months ago (2009-06-19 23:04:34 UTC) #5
wtc
On 2009/06/19 23:04:34, dank wrote: > It just hangs for me. For instance, ftp://ftp.gnu.org > ...
11 years, 6 months ago (2009-06-23 02:10:14 UTC) #6
wtc
11 years, 6 months ago (2009-06-23 18:19:40 UTC) #7
On 2009/06/19 23:04:34, dank wrote:
> It just hangs for me.  For instance, ftp://ftp.gnu.org
> doesn't work.  

Ibrar,

I found one case that hangs for me.  Could you look into this?

1. Go to ftp://ftp.mozilla.org/pub/
2. Click the "addons" link.

Thanks.

Powered by Google App Engine
This is Rietveld 408576698