Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 1193383002: Oilpan: have media element prefinalizer handle all finalization. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: move conditional closing of MediaSource to media elt prefinalizer Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLMediaElement.h
diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h
index db317f5f58a4b61e62358f652528ffa95fa168b4..55e40b76aa59a6529548449bfca89edfad189542 100644
--- a/Source/core/html/HTMLMediaElement.h
+++ b/Source/core/html/HTMLMediaElement.h
@@ -271,17 +271,6 @@ public:
// Returns the "effective media volume" value as specified in the HTML5 spec.
double effectiveMediaVolume() const;
-#if ENABLE(OILPAN)
- // Oilpan: finalization of the media element is observable from its
- // attached MediaSource; it entering a closed state.
- //
- // Express that by having the MediaSource keep a weak reference
- // to the media element and signal that it wants to be notified
- // of destruction if it survives a GC, but the media element
- // doesn't.
- void setCloseMediaSourceWhenFinalizing();
-#endif
-
// Predicates also used when dispatching wrapper creation (cf. [SpecialWrapFor] IDL attribute usage.)
virtual bool isHTMLAudioElement() const { return false; }
virtual bool isHTMLVideoElement() const { return false; }
@@ -557,10 +546,7 @@ private:
bool m_processingPreferenceChange : 1;
bool m_remoteRoutesAvailable : 1;
bool m_playingRemotely : 1;
-#if ENABLE(OILPAN)
bool m_isFinalizing : 1;
- bool m_closeMediaSourceWhenFinalizing : 1;
-#endif
bool m_initialPlayWithoutUserGestures : 1;
bool m_autoplayMediaCounted : 1;
« no previous file with comments | « no previous file | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698