Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1193363004: PPC: Clean up JSConstructStub (Closed)

Created:
5 years, 6 months ago by MTBrandyberry
Modified:
5 years, 6 months ago
Reviewers:
michael_dawson, dstence
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Clean up JSConstructStub Port 882055ff6a58f6b585575229f40f364e5f2a3ad0 Original commit message: - fix truthfulness of comments - use InitializeFieldsWithFiller more consistently - use unsigned comparisons for pointers No change in functionality intended. Bonus: improve JavaScriptFrame::Print() for an enhanced debugging experience: - print PC of each frame - print the function's source also for optimized frames R=dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/464f05385ef2abe3c1d0b7721b085feb6878f30b Cr-Commit-Position: refs/heads/master@{#29197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/ppc/builtins-ppc.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 6 months ago (2015-06-22 17:44:18 UTC) #1
dstence
lgtm
5 years, 6 months ago (2015-06-22 17:47:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193363004/1
5 years, 6 months ago (2015-06-22 17:47:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-22 18:16:38 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 18:16:54 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/464f05385ef2abe3c1d0b7721b085feb6878f30b
Cr-Commit-Position: refs/heads/master@{#29197}

Powered by Google App Engine
This is Rietveld 408576698