Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1193343002: Move SetFastDoubleElementsCapacity into GrowCapacityAndConvert (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move SetFastDoubleElementsCapacity into GrowCapacityAndConvert BUG=v8:4137 LOG=n Committed: https://crrev.com/6c7449a636e3c1d58cc3a821706f93de4bae970a Cr-Commit-Position: refs/heads/master@{#29182}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -77 lines) Patch
M src/elements.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/elements.cc View 4 chunks +36 lines, -5 lines 0 comments Download
M src/lookup.cc View 1 chunk +3 lines, -19 lines 0 comments Download
M src/objects.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/objects.cc View 1 chunk +4 lines, -39 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +1 line, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal next up same for SetFastElementsCapacity
5 years, 6 months ago (2015-06-22 10:25:58 UTC) #2
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-22 10:59:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193343002/1
5 years, 6 months ago (2015-06-22 10:59:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-22 11:24:09 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 11:24:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c7449a636e3c1d58cc3a821706f93de4bae970a
Cr-Commit-Position: refs/heads/master@{#29182}

Powered by Google App Engine
This is Rietveld 408576698