Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4571)

Unified Diff: chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h

Issue 1193333017: Added system log uploader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved SystemLogUploadJob creation to DeviceCloudPolicyManager. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h
diff --git a/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h b/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h
index a83054291f5838ee955786a56a9064d220072c1c..d5e361b02e062c793f222a607e0068666c0f5d80 100644
--- a/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h
+++ b/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h
@@ -37,6 +37,7 @@ class DeviceCloudPolicyStoreChromeOS;
class EnterpriseInstallAttributes;
class HeartbeatScheduler;
class StatusUploader;
+class SystemLogUploader;
// CloudPolicyManager specialization for device policy on Chrome OS.
class DeviceCloudPolicyManagerChromeOS : public CloudPolicyManager {
@@ -122,6 +123,9 @@ class DeviceCloudPolicyManagerChromeOS : public CloudPolicyManager {
// Factory function to create the StatusUploader.
void CreateStatusUploader();
+ // Factory function to create the SystemLogUploader.
+ void CreateSystemLogUploader();
+
// Points to the same object as the base CloudPolicyManager::store(), but with
// actual device policy specific type.
scoped_ptr<DeviceCloudPolicyStoreChromeOS> device_store_;
@@ -131,11 +135,14 @@ class DeviceCloudPolicyManagerChromeOS : public CloudPolicyManager {
// state.
scoped_ptr<StatusUploader> status_uploader_;
+ // Helper object that handles uploading system logs to the server.
+ scoped_ptr<SystemLogUploader> syslog_uploader_;
+
// Helper object that handles sending heartbeats over the GCM channel to
// the server, to monitor connectivity.
scoped_ptr<HeartbeatScheduler> heartbeat_scheduler_;
- // The TaskRunner used to do device status uploads.
+ // The TaskRunner used to do device status and logs uploads.
Andrew T Wilson (Slow) 2015/06/29 15:06:08 nit: "log uploads"
Polina Bondarenko 2015/07/02 15:28:03 Done.
scoped_refptr<base::SequencedTaskRunner> task_runner_;
ServerBackedStateKeysBroker::Subscription state_keys_update_subscription_;

Powered by Google App Engine
This is Rietveld 408576698