Added system log uploader.

chrome/browser/chromeos/policy/system_log_uploader.cc

+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/files/file_util.h"
+#include "base/location.h"
+#include "base/strings/stringprintf.h"
+#include "base/task_runner_util.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/chromeos/policy/system_log_uploader.h"
+#include "chrome/browser/chromeos/policy/upload_job_impl.h"
+#include "chrome/browser/chromeos/settings/device_oauth2_token_service.h"
+#include "chrome/browser/chromeos/settings/device_oauth2_token_service_factory.h"
+#include "content/public/browser/browser_thread.h"
+#include "net/http/http_request_headers.h"
+
+namespace {
+// Determines the time between log uploads.
+const int64 kDefaultUploadDelayMs = 12 * 60 * 60 * 1000;  // 12 hours
+
+// Determines the time, measured from the time of last failed upload,
+// after which the log upload is retried.
+const int64 kErrorUploadDelayMs = 120 * 1000;  // 120 seconds
+
+// The maximum number of successive retries.
+const int kMaxNumRetries = 1;
+
+// String constant defining the url we upload system logs to.
+const char* kSystemLogUploadUrl =
+    "https://m.google.com/devicemanagement/data/api/upload";
+
+// String constant identifying the header field which stores the file type.
+const char* kFileTypeHeaderName = "File-Type";
+
+// String constant signalling that the data segment contains log files.
+const char* const kFileTypeLogFile = "log_file";
+
+// String constant signalling that the segment contains a plain text.
+const char* const kContentTypePlainText = "text/plain";
+
+// Template string constant for populating the name field.
+const char* const kNameFieldTemplate = "file%d";
+
+// The file names of the system logs to upload.
+// Note: do not add anything to this list without checking for PII in the file.
+const char* const kSystemLogFileNames[] = {"/var/log/bios_info.txt",
+                                           "/var/log/chrome/chrome",
+                                           "/var/log/eventlog.txt",
+                                           "/var/log/messages",
+                                           "/var/log/net.log",
+                                           "/var/log/platform_info.txt",
+                                           "/var/log/ui/ui.LATEST",
+                                           "/var/log/update_engine.log"};
+
+// Reads the system log files as binary files, stores the files as pairs
+// (file name, data) and returns. Called on blocking thread.
+policy::SystemLogUploader::SystemLogs ReadFiles() {
+  policy::SystemLogUploader::SystemLogs system_logs;

[Andrew T Wilson (Slow), 2015/08/03 09:55:50]

This is going to make multiple copies of all of the file data, isn't it (when
you return this to the caller)? Not a huge issue, but still would be nice to
structure this not to do this (pass in a pre-allocated vector to fill in, or
else have this return a scoped_ptr<SystemLogs> or something like that)?

[Polina Bondarenko, 2015/08/03 11:53:13]

Done.

+  for (auto const file_path : kSystemLogFileNames) {
+    if (!base::PathExists(base::FilePath(file_path)))
+      continue;
+    std::string data = std::string();
+    if (!base::ReadFileToString(base::FilePath(file_path), &data)) {
+      LOG(ERROR) << "Failed to read the system log file from the disk "
+                 << file_path << std::endl;
+    }
+    // TODO(pbond): add check |data| for common PII (email, IP addresses and
+    // etc.) and not upload |data| if any is found. http://crbug.com/515879.

[Andrew T Wilson (Slow), 2015/08/03 09:55:50]

Better than not uploading data would be to modify the data to remove/obfuscate
the PII.

[Polina Bondarenko, 2015/08/03 11:53:13]

Done.

+    system_logs.push_back(std::make_pair(file_path, data));
+  }
+  return system_logs;
+}
+
+// An implementation of the |SystemLogUploader::Delegate|, that is used to
+// create an upload job and load system logs from the disk.
+class SystemLogDelegate : public policy::SystemLogUploader::Delegate {
+ public:
+  SystemLogDelegate();
+  ~SystemLogDelegate() override;
+
+  // SystemLogUploader::Delegate:
+  void LoadSystemLogs(const LogUploadCallback& upload_callback) override;
+
+  scoped_ptr<policy::UploadJob> CreateUploadJob(
+      const GURL& upload_url,
+      policy::UploadJob::Delegate* delegate) override;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(SystemLogDelegate);
+};
+
+SystemLogDelegate::SystemLogDelegate() {
+}
+
+SystemLogDelegate::~SystemLogDelegate() {
+}
+
+void SystemLogDelegate::LoadSystemLogs(
+    const LogUploadCallback& upload_callback) {
+  // Run ReadFiles() in the thread that interacts with the file system and
+  // return system logs to |upload_callback| on the current thread.
+  base::PostTaskAndReplyWithResult(content::BrowserThread::GetBlockingPool(),
+                                   FROM_HERE, base::Bind(&ReadFiles),
+                                   upload_callback);
+}
+
+scoped_ptr<policy::UploadJob> SystemLogDelegate::CreateUploadJob(
+    const GURL& upload_url,
+    policy::UploadJob::Delegate* delegate) {
+  chromeos::DeviceOAuth2TokenService* device_oauth2_token_service =
+      chromeos::DeviceOAuth2TokenServiceFactory::Get();
+
+  scoped_refptr<net::URLRequestContextGetter> system_request_context =
+      g_browser_process->system_request_context();
+  std::string robot_account_id =
+      device_oauth2_token_service->GetRobotAccountId();
+  return scoped_ptr<policy::UploadJob>(new policy::UploadJobImpl(
+      upload_url, robot_account_id, device_oauth2_token_service,
+      system_request_context, delegate,
+      make_scoped_ptr(new policy::UploadJobImpl::RandomMimeBoundaryGenerator)));
+}
+
+}  // namespace
+
+namespace policy {
+
+SystemLogUploader::SystemLogUploader(
+    scoped_ptr<Delegate> syslog_delegate,
+    const scoped_refptr<base::SequencedTaskRunner>& task_runner)
+    : retry_count_(0),
+      upload_frequency_(
+          base::TimeDelta::FromMilliseconds(kDefaultUploadDelayMs)),
+      task_runner_(task_runner),
+      syslog_delegate_(syslog_delegate.Pass()),
+      weak_factory_(this) {
+  if (!syslog_delegate_)
+    syslog_delegate_.reset(new SystemLogDelegate());
+  DCHECK(syslog_delegate_);
+  // Immediately schedule the next system log upload (last_upload_attempt_ is
+  // set to the start of the epoch, so this will trigger an update upload in the
+  // immediate future).
+  ScheduleNextSystemLogUpload(upload_frequency_);
+}
+
+SystemLogUploader::~SystemLogUploader() {
+}
+
+void SystemLogUploader::OnSuccess() {
+  upload_job_.reset();
+  last_upload_attempt_ = base::Time::NowFromSystemTime();
+  retry_count_ = 0;
+
+  // On successful log upload schedule the next log upload after
+  // upload_frequency_ time from now.
+  ScheduleNextSystemLogUpload(upload_frequency_);
+}
+
+void SystemLogUploader::OnFailure(UploadJob::ErrorCode error_code) {
+  upload_job_.reset();
+  last_upload_attempt_ = base::Time::NowFromSystemTime();
+
+  //  If we have hit the maximum number of retries, terminate this upload
+  //  attempt and schedule the next one using the normal delay. Otherwise, retry
+  //  uploading after kErrorUploadDelayMs milliseconds.
+  if (retry_count_++ < kMaxNumRetries) {
+    ScheduleNextSystemLogUpload(
+        base::TimeDelta::FromMilliseconds(kErrorUploadDelayMs));
+  } else {
+    // No more retries.
+    retry_count_ = 0;
+    ScheduleNextSystemLogUpload(upload_frequency_);
+  }
+}
+
+void SystemLogUploader::UploadSystemLogs(const SystemLogs& system_logs) {
+  // Must be called on the main thread.
+  DCHECK(thread_checker_.CalledOnValidThread());
+  DCHECK(!upload_job_);
+
+  GURL upload_url(kSystemLogUploadUrl);
+  DCHECK(upload_url.is_valid());
+  upload_job_ = syslog_delegate_->CreateUploadJob(upload_url, this);
+
+  // Start a system log upload.
+  int file_number = 1;
+  for (const auto& syslog_entry : system_logs) {
+    std::map<std::string, std::string> header_fields;
+    scoped_ptr<std::string> data =
+        make_scoped_ptr(new std::string(syslog_entry.second));
+    header_fields.insert(std::make_pair(kFileTypeHeaderName, kFileTypeLogFile));
+    header_fields.insert(std::make_pair(net::HttpRequestHeaders::kContentType,
+                                        kContentTypePlainText));
+    upload_job_->AddDataSegment(
+        base::StringPrintf(kNameFieldTemplate, file_number), syslog_entry.first,
+        header_fields, data.Pass());
+    ++file_number;
+  }
+  upload_job_->Start();
+}
+
+void SystemLogUploader::StartLogUpload() {
+  // Must be called on the main thread.
+  DCHECK(thread_checker_.CalledOnValidThread());
+
+  syslog_delegate_->LoadSystemLogs(base::Bind(
+      &SystemLogUploader::UploadSystemLogs, weak_factory_.GetWeakPtr()));
+}
+
+void SystemLogUploader::ScheduleNextSystemLogUpload(base::TimeDelta frequency) {

[Andrew T Wilson (Slow), 2015/08/03 09:55:50]

BTW, would be nice if we had a DCHECK in place to ensure we never have more than
one pending delayed task. Is that possible? Alternatively, you could just reset
your weak_factory_ in this routine.

[Polina Bondarenko, 2015/08/03 11:53:13]

Done, added weak_factory_.reset, because we use the same task_runner_ as the
status uploader.

+  // Calculate when to fire off the next update.
+  base::TimeDelta delay = std::max(
+      (last_upload_attempt_ + frequency) - base::Time::NowFromSystemTime(),
+      base::TimeDelta());
+  task_runner_->PostDelayedTask(FROM_HERE,
+                                base::Bind(&SystemLogUploader::StartLogUpload,
+                                           weak_factory_.GetWeakPtr()),
+                                delay);
+}
+
+}  // namespace policy