Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1193333012: Fix depot_tools presubmit tests by mocking multiprocessing.cpu_count. (Closed)

Created:
5 years, 6 months ago by iannucci
Modified:
5 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix depot_tools presubmit tests by mocking multiprocessing.cpu_count. R=thakis@chromium.org BUG=503462 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tests/presubmit_unittest.py View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
iannucci
5 years, 6 months ago (2015-06-23 04:00:39 UTC) #1
Nico
lgtm, that seems to do the trick. Thanks for the very fast fix!
5 years, 6 months ago (2015-06-23 04:06:45 UTC) #2
iannucci
On 2015/06/23 04:06:45, Nico (afk Mon Jun 22) wrote: > lgtm, that seems to do ...
5 years, 6 months ago (2015-06-23 04:07:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193333012/1
5 years, 6 months ago (2015-06-23 04:07:31 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 04:09:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295795

Powered by Google App Engine
This is Rietveld 408576698