Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp

Issue 1193333002: Address peter's comments from past review (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp
diff --git a/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp b/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp
index fbfe6510495216865ece7887e25474bfa2d56fbd..b451b6488e9de300836a3d6fba1b51c00d41b943 100644
--- a/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp
+++ b/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp
@@ -20,7 +20,6 @@ HTMLMediaElementAudioOutputDevice::HTMLMediaElementAudioOutputDevice()
String HTMLMediaElementAudioOutputDevice::sinkId(HTMLMediaElement& element)
{
- WTF_LOG(Media, __FUNCTION__);
HTMLMediaElementAudioOutputDevice& aodElement = HTMLMediaElementAudioOutputDevice::from(element);
return aodElement.m_sinkId;
}
@@ -32,7 +31,6 @@ void HTMLMediaElementAudioOutputDevice::setSinkId(const String& sinkId)
ScriptPromise HTMLMediaElementAudioOutputDevice::setSinkId(ScriptState* scriptState, HTMLMediaElement& element, const String& sinkId)
{
- WTF_LOG(Media, __FUNCTION__);
WebMediaPlayer* webMediaPlayer = element.webMediaPlayer();
if (!webMediaPlayer)
return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(AbortError, "No media player available"));
« no previous file with comments | « no previous file | Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698