Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.idl - Issue 1193333002: Address peter's comments from past review

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.idl

Issue 1193333002: Address peter's comments from past review (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // http://w3c.github.io/mediacapture-output/#htmlmediaelement-extensions	5 // https://w3c.github.io/mediacapture-output/#htmlmediaelement-extensions

6	6

7 partial interface HTMLMediaElement {	7 partial interface HTMLMediaElement {

8 [RuntimeEnabled=AudioOutputDevices] readonly attribute DOMString sinkId;	8 [RuntimeEnabled=AudioOutputDevices] readonly attribute DOMString sinkId;

9 [RuntimeEnabled=AudioOutputDevices, TypeChecking=Interface, CallWith=ScriptS tate] Promise<void> setSinkId(DOMString sinkId);	9 [RuntimeEnabled=AudioOutputDevices, TypeChecking=Interface, CallWith=ScriptS tate] Promise<void> setSinkId(DOMString sinkId);

10 };	10 };

11	11

OLD	NEW

« no previous file with comments | « Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp ('k') | no next file » | no next file with comments »