Issue 1193333002: Address peter's comments from past review

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1193333002: Address peter's comments from past review (Closed)

Created:
4 years, 10 months ago by Guido Urdaneta

Modified:
4 years, 10 months ago

Reviewers:
Peter Beverloo

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp	View		2 chunks	+0 lines, -2 lines	0 comments	Download
	M	Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.idl	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Peter Beverloo

lgtm, thanks! Don't forget to send out reviews :-)

4 years, 10 months ago (2015-06-29 13:12:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193333002/1

4 years, 10 months ago (2015-06-29 13:52:29 UTC) #4

commit-bot: I haz the power

4 years, 10 months ago (2015-06-29 16:22:04 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197999