[Android] Consolidate touch handling code in ContentViewGestureHandler

[Android] Consolidate touch handling code in ContentViewGestureHandler

Unify the code that dispatches touch events to native, making it easier to
follow touch event flow through the pipeline.  Also guard against nested loops
for touch dispatch, triggered by synchronous acks when there are multiply
enqueud touch events.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242124

[jdduke (slow), 2013-12-19 17:03:35]

skyostil@: PTAL. This isn't so much fixing any problems as it is refactoring the
entry points to where we process and send touch events to native.  The nested
dispatch guard is also speculative, but I don't think it hurts. What do you
think?

[Sami, 2013-12-19 18:33:22]

lgtm % nits, thanks for your continued effort in untangling this class Jared :)

I'm not sure if the re-entrancy guard is needed, but having it won't hurt. Maybe
it could have a trace event if we really want to know if it's been hit, but
maybe that's not really necessary.

https://codereview.chromium.org/119333002/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java
(right):

https://codereview.chromium.org/119333002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java:864:
TraceEvent.instant("QueueEvent:EventCoalesced",
nit: lower case q to match the method name.

https://codereview.chromium.org/119333002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java:877:
MotionEvent clone = MotionEvent.obtain(event);
Please keep the comment about why cloning is needed since it's easy to miss
that.

https://codereview.chromium.org/119333002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java:882:
TraceEvent.instant("QueueEvent:EventQueued",
nit: lower case q to match the method name.

[jdduke (slow), 2013-12-19 20:06:35]

Thanks for review!

https://codereview.chromium.org/119333002/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java
(right):

https://codereview.chromium.org/119333002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java:864:
TraceEvent.instant("QueueEvent:EventCoalesced",
On 2013/12/19 18:33:22, Sami wrote:
> nit: lower case q to match the method name.

Done.

https://codereview.chromium.org/119333002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java:877:
MotionEvent clone = MotionEvent.obtain(event);
On 2013/12/19 18:33:22, Sami wrote:
> Please keep the comment about why cloning is needed since it's easy to miss
> that.

Done.

https://codereview.chromium.org/119333002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java:882:
TraceEvent.instant("QueueEvent:EventQueued",
On 2013/12/19 18:33:22, Sami wrote:
> nit: lower case q to match the method name.

Done.

[commit-bot: I haz the power, 2013-12-19 20:07:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/119333002/20001

[commit-bot: I haz the power, 2013-12-20 01:20:57]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-12-20 01:25:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/119333002/20001

[commit-bot: I haz the power, 2013-12-20 08:55:41]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-12-20 14:02:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/119333002/20001

[commit-bot: I haz the power, 2013-12-20 17:48:31]

Change committed as 242124