Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issue 1193273003: Revert "Add Resource class. Currently unimplemented." (Closed)

Created:
5 years, 6 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 6 months ago
Reviewers:
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add Resource class. Currently unimplemented." This reverts commit 2890a7a2a94ff54c7c0050e69c40ca6a60a28474. Causes a dart2js test error and a significant amount of analyzer warnings. Committed: https://github.com/dart-lang/sdk/commit/78a3db312824f12bca6c3a4d147fcef6a411da69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -148 lines) Patch
M runtime/lib/core_patch.dart View 1 chunk +0 lines, -24 lines 0 comments Download
M runtime/lib/internal_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/core_patch.dart View 1 chunk +0 lines, -68 lines 0 comments Download
M sdk/lib/core/core.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M sdk/lib/core/core_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D sdk/lib/core/resource.dart View 1 chunk +0 lines, -52 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Lasse Reichstein Nielsen
5 years, 6 months ago (2015-06-22 14:44:01 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
78a3db312824f12bca6c3a4d147fcef6a411da69 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698