Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 119323008: telemetry: Fix screen recording with multiple connected devices (Closed)

Created:
6 years, 11 months ago by Sami
Modified:
6 years, 11 months ago
Reviewers:
bulach, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

telemetry: Fix screen recording with multiple connected devices Make it possible to use the Android screen recording profiler with multiple connected devices. Only the screen on the device that is actually running the telemetry test will get recorded. BUG=331435 TEST=tools/perf/run_benchmark smoothness.key_mobile_sites \ --page-filter=linus --browser=android-content-shell \ --profiler=android-screen-recorder NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243080

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M tools/telemetry/telemetry/core/platform/profiler/android_screen_recorder_profiler.py View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sami
6 years, 11 months ago (2014-01-03 17:24:10 UTC) #1
tonyg
lgtm
6 years, 11 months ago (2014-01-05 19:58:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/119323008/1
6 years, 11 months ago (2014-01-06 10:33:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/119323008/1
6 years, 11 months ago (2014-01-06 10:34:09 UTC) #4
commit-bot: I haz the power
Change committed as 243080
6 years, 11 months ago (2014-01-06 10:34:19 UTC) #5
bulach
6 years, 11 months ago (2014-01-07 11:22:24 UTC) #6
Message was sent while issue was closed.
late lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698