Source/core/css/CSSToLengthConversionData.h - Issue 1193203003: Keep effectiveZoom finite

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSToLengthConversionData.h

Issue 1193203003: Keep effectiveZoom finite (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Reduced clamp range; Remove clamp in CSSToLength... Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSToLengthConversionData.h

diff --git a/Source/core/css/CSSToLengthConversionData.h b/Source/core/css/CSSToLengthConversionData.h

index c2ee15e1a4d889db54c5190cda2354bfb0fea3b0..e60408130b9b7cb95e8a0038ebaf682cd40d6a27 100644

--- a/Source/core/css/CSSToLengthConversionData.h

+++ b/Source/core/css/CSSToLengthConversionData.h

@@ -92,7 +92,11 @@ public:

double viewportMaxPercent() const;

void setFontSizes(const FontSizes& fontSizes) { m_fontSizes = fontSizes; }

- void setZoom(float zoom) { m_zoom = clampTo<float>(zoom, std::numeric_limits<float>::denorm_min()); }

+ void setZoom(float zoom)

+ {

+ ASSERT(std::isfinite(zoom) && zoom > 0);

+ m_zoom = zoom;

+ }

CSSToLengthConversionData copyWithAdjustedZoom(float newZoom) const

{