Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 11932002: mac: Remove OwnershipPolicy parameter to scoped_nsobject. (Closed)

Created:
7 years, 11 months ago by Nico
Modified:
7 years, 11 months ago
Reviewers:
Mark Mentovai, qsr
CC:
chromium-reviews, penghuang+watch_chromium.org, groby+watch_chromium.org, yusukes+watch_chromium.org, jam, James Su, jianli, gavinp+memory_chromium.org, sail+watch_chromium.org, Dmitry Titov, joi+watch-content_chromium.org, jennb, darin-cc_chromium.org, dcheng, gbillock+watch_chromium.org, smckay+watch_chromium.org, erikwright+watch_chromium.org, rouslan+watch_chromium.org, sail
Visibility:
Public.

Description

mac: Remove OwnershipPolicy parameter to scoped_nsobject. The client code gets shorter, the implementation gets shorter, and there are fewer concepts to remember. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177200

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -43 lines) Patch
M base/memory/scoped_nsobject.h View 1 6 chunks +12 lines, -35 lines 0 comments Download
M base/memory/scoped_nsobject_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/web_intents_button_decoration.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
7 years, 11 months ago (2013-01-15 21:14:24 UTC) #1
Mark Mentovai
We can’t get rid of this. The iPhoneys use it. We added it to support ...
7 years, 11 months ago (2013-01-15 21:32:18 UTC) #2
Nico
On 2013/01/15 21:32:18, Mark Mentovai wrote: > We can’t get rid of this. The iPhoneys ...
7 years, 11 months ago (2013-01-15 21:33:17 UTC) #3
Mark Mentovai
The checkin comment has all of the context that I remember: https://codereview.chromium.org/9349016 If qsr says ...
7 years, 11 months ago (2013-01-15 21:35:28 UTC) #4
Nico
qsr: Mark says you added this (in https://codereview.chromium.org/9349016). Do you really need this? What for?
7 years, 11 months ago (2013-01-15 21:39:41 UTC) #5
qsr
Nothing. Mark: You asked me to add this when I spoke about changing scoped_nsobject to ...
7 years, 11 months ago (2013-01-16 09:02:12 UTC) #6
Mark Mentovai
7 years, 11 months ago (2013-01-16 13:19:27 UTC) #7
LGTM then.

Powered by Google App Engine
This is Rietveld 408576698