Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: chrome/browser/resources/options/password_manager.js

Issue 1193143003: Enable import/export of passwords into/from Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/password_manager.js
diff --git a/chrome/browser/resources/options/password_manager.js b/chrome/browser/resources/options/password_manager.js
index a6ee22c8f0358b8225e528ee9b6b611567673ad0..b577701a9cc1f004cc02f46f30017935b5c011b0 100644
--- a/chrome/browser/resources/options/password_manager.js
+++ b/chrome/browser/resources/options/password_manager.js
@@ -66,6 +66,14 @@ cr.define('options', function() {
PageManager.closeOverlay();
};
+ $('password-manager-import').onclick = function() {
+ chrome.send('importPassword');
+ };
+
+ $('password-manager-export').onclick = function() {
+ chrome.send('exportPassword');
+ };
+
$('password-search-box').addEventListener('search',
this.handleSearchQueryChange_.bind(this));
@@ -270,6 +278,19 @@ cr.define('options', function() {
var item = this.savedPasswordsList_.getListItemByIndex(index);
item.showPassword(password);
},
+
+ /**
+ * @param {boolean} visible Whether the link should be visible.
+ * @private
+ */
+ setManageAccountLinkVisibility_: function(visible) {
+ $('manage-passwords-span').hidden = !visible;
+ },
+
+ showImportExportButton_: function() {
Finnur 2016/04/18 14:25:46 This fails the Closure compile: ## /media/largedr
vabr (Chromium) 2016/04/19 12:43:10 This was fixed by dbeam@ in https://codereview.chr
+ $('password-manager-import').hidden = false;
+ $('password-manager-export').hidden = false;
+ },
};
/**
@@ -277,9 +298,9 @@ cr.define('options', function() {
* @param {number} rowIndex indicating the row to remove.
*/
PasswordManager.removeSavedPassword = function(rowIndex) {
- chrome.send('removeSavedPassword', [String(rowIndex)]);
- chrome.send('coreOptionsUserMetricsAction',
- ['Options_PasswordManagerDeletePassword']);
+ chrome.send('removeSavedPassword', [String(rowIndex)]);
+ chrome.send('coreOptionsUserMetricsAction',
+ ['Options_PasswordManagerDeletePassword']);
};
/**
@@ -287,7 +308,7 @@ cr.define('options', function() {
* @param {number} rowIndex indicating the row to remove.
*/
PasswordManager.removePasswordException = function(rowIndex) {
- chrome.send('removePasswordException', [String(rowIndex)]);
+ chrome.send('removePasswordException', [String(rowIndex)]);
};
PasswordManager.requestShowPassword = function(index) {
@@ -298,7 +319,8 @@ cr.define('options', function() {
cr.makePublic(PasswordManager, [
'setSavedPasswordsList',
'setPasswordExceptionsList',
- 'showPassword'
+ 'showImportExportButton',
+ 'showPassword',
]);
// Export

Powered by Google App Engine
This is Rietveld 408576698