Enable import/export of passwords into/from Password Manager

chrome/browser/resources/options/password_manager.js

Index: chrome/browser/resources/options/password_manager.js
diff --git a/chrome/browser/resources/options/password_manager.js b/chrome/browser/resources/options/password_manager.js
index a6ee22c8f0358b8225e528ee9b6b611567673ad0..bd1085b36578cae0d77a01f389abebb808634a4c 100644
--- a/chrome/browser/resources/options/password_manager.js
+++ b/chrome/browser/resources/options/password_manager.js
@@ -59,6 +59,8 @@ cr.define('options', function() {
     initializePage: function() {
       Page.prototype.initializePage.call(this);
 
+      var self = this;

[Evan Stade, 2016/04/06 21:25:22]

is this used somewhere?

[xunlu, 2016/04/08 15:38:21]

Done.

+
       $('auto-signin-block').hidden =
           !loadTimeData.getBoolean('enableCredentialManagerAPI');
 
@@ -66,8 +68,16 @@ cr.define('options', function() {
         PageManager.closeOverlay();
       };
 
+      $('password-manager-import').onclick = function() {
+        chrome.send('importPassword');
+      };
+
+      $('password-manager-export').onclick = function() {
+        chrome.send('exportPassword');
+      };
+
       $('password-search-box').addEventListener('search',
-          this.handleSearchQueryChange_.bind(this));
+        this.handleSearchQueryChange_.bind(this));

[Evan Stade, 2016/04/06 21:25:22]

seems like the indentation was correct before

[xunlu, 2016/04/08 15:38:21]

Done.

 
       $('exceptions-learn-more').onclick = function() {
         chrome.send('coreOptionsUserMetricsAction',
@@ -270,6 +280,19 @@ cr.define('options', function() {
       var item = this.savedPasswordsList_.getListItemByIndex(index);
       item.showPassword(password);
     },
+
+    /**
+     * @param {boolean} visible Whether the link should be visible.
+     * @private
+     */
+    setManageAccountLinkVisibility_: function(visible) {
+      $('manage-passwords-span').hidden = !visible;
+    },
+
+    showImportExportButton_: function() {
+      $('password-manager-import').disabled = false;
+      $('password-manager-export').disabled = false;
+    },
   };
 
   /**
@@ -277,8 +300,8 @@ cr.define('options', function() {
    * @param {number} rowIndex indicating the row to remove.
    */
   PasswordManager.removeSavedPassword = function(rowIndex) {
-      chrome.send('removeSavedPassword', [String(rowIndex)]);
-      chrome.send('coreOptionsUserMetricsAction',
+    chrome.send('removeSavedPassword', [String(rowIndex)]);
+    chrome.send('coreOptionsUserMetricsAction',
                   ['Options_PasswordManagerDeletePassword']);

[Evan Stade, 2016/04/06 21:25:22]

I think this indent needs to change too

[xunlu, 2016/04/08 15:38:21]

Done.

   };
 
@@ -287,7 +310,7 @@ cr.define('options', function() {
    * @param {number} rowIndex indicating the row to remove.
    */
   PasswordManager.removePasswordException = function(rowIndex) {
-      chrome.send('removePasswordException', [String(rowIndex)]);
+    chrome.send('removePasswordException', [String(rowIndex)]);
   };
 
   PasswordManager.requestShowPassword = function(index) {
@@ -298,7 +321,8 @@ cr.define('options', function() {
   cr.makePublic(PasswordManager, [
     'setSavedPasswordsList',
     'setPasswordExceptionsList',
-    'showPassword'
+    'showPassword',
+    'showImportExportButton'

[Evan Stade, 2016/04/06 21:25:22]

nit: add a final comma
nit 2: alphabetize

[xunlu, 2016/04/08 15:38:21]

Done.

   ]);
 
   // Export