components/password_manager/core/browser/import/csv_reader.h - Issue 1193143003: Enable import/export of passwords into/from Password Manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/import/csv_reader.h

Issue 1193143003: Enable import/export of passwords into/from Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/options/password_manager_handler.cc ('K') | « components/password_manager/core/browser/export/password_exporter_unittest.cc ('k') | components/password_manager/core/browser/import/csv_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/import/csv_reader.h

diff --git a/components/password_manager/core/browser/import/csv_reader.h b/components/password_manager/core/browser/import/csv_reader.h

index b1dcde5d34cf12b11e2d1b51f587501014df11c5..fc639821b4308ba2bd5d5b52e874396b1451ac75 100644

--- a/components/password_manager/core/browser/import/csv_reader.h

+++ b/components/password_manager/core/browser/import/csv_reader.h

@@ -5,12 +5,11 @@

#ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_EXPORT_CSV_READER_H_

#define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_EXPORT_CSV_READER_H_

-#include <map>

-#include <string>

#include <vector>

#include "base/macros.h"

#include "base/strings/string_piece.h"

+#include "components/password_manager/core/browser/types.h"

namespace password_manager {

@@ -34,7 +33,7 @@ namespace password_manager {

// failed due to a syntax error.

bool ReadCSV(base::StringPiece csv,

std::vector<std::string>* column_names,

- std::vector<std::map<std::string, std::string>>* records);

+ std::vector<ColumnNameToValueMap>* records);

} // namespace password_manager