components/password_manager/core/browser/import/csv_reader.cc - Issue 1193143003: Enable import/export of passwords into/from Password Manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/import/csv_reader.cc

Issue 1193143003: Enable import/export of passwords into/from Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add finch switch and address comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/password_manager_presenter.cc ('K') | « components/password_manager/core/browser/import/csv_reader.h ('k') | components/password_manager/core/browser/import/password_importer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/import/csv_reader.cc

diff --git a/components/password_manager/core/browser/import/csv_reader.cc b/components/password_manager/core/browser/import/csv_reader.cc

index c2c641c911cd2ff980434e577f36ac514edb009d..c8873e396f8e1ed68327f7037dfca134ec60cd25 100644

--- a/components/password_manager/core/browser/import/csv_reader.cc

+++ b/components/password_manager/core/browser/import/csv_reader.cc

@@ -96,7 +96,7 @@ namespace password_manager {

bool ReadCSV(base::StringPiece csv,

std::vector<std::string>* column_names,

- std::vector<std::map<std::string, std::string>>* records) {

+ std::vector<ColumnNameToValueMap>* records) {

DCHECK(column_names);

DCHECK(records);