Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7181)

Unified Diff: chrome/browser/resources/options/password_manager.js

Issue 1193143003: Enable import/export of passwords into/from Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/password_manager.js
diff --git a/chrome/browser/resources/options/password_manager.js b/chrome/browser/resources/options/password_manager.js
index 6e16ebac5e14d48e2cba966de98e8638f585fa26..03d1156a2dfbc7e0f4ebb9dcf99f1edab362de74 100644
--- a/chrome/browser/resources/options/password_manager.js
+++ b/chrome/browser/resources/options/password_manager.js
@@ -59,6 +59,8 @@ cr.define('options', function() {
initializePage: function() {
Page.prototype.initializePage.call(this);
+ var thiz = this;
Garrett Casto 2015/06/23 23:42:35 It looks like this variable is named "self" in mos
xunlu 2015/06/25 17:12:15 Right. I actually named it "self" until I saw the
Garrett Casto 2015/06/26 21:13:48 Perhaps, but given that it's common practice for o
xunlu 2015/06/30 23:06:09 Done.
+
$('auto-signin-block').hidden =
!loadTimeData.getBoolean('enableCredentialManagerAPI');
@@ -66,8 +68,20 @@ cr.define('options', function() {
PageManager.closeOverlay();
};
+ $('password-manager-import-confirm').onclick = function() {
+ thiz.setImportCompleteUIVisibility_(false);
+ };
+
+ $('password-manager-import').onclick = function() {
+ chrome.send('importPassword');
+ };
+
+ $('password-manager-export').onclick = function() {
+ chrome.send('exportPassword');
+ };
+
$('password-search-box').addEventListener('search',
- this.handleSearchQueryChange_.bind(this));
+ this.handleSearchQueryChange_.bind(this));
$('exceptions-learn-more').onclick = function() {
chrome.send('coreOptionsUserMetricsAction',
@@ -89,6 +103,7 @@ cr.define('options', function() {
// Updating the password lists may cause a blocking platform dialog pop up
// (Mac, Linux), so we delay this operation until the page is shown.
chrome.send('updatePasswordLists');
+ this.setImportCompleteUIVisibility_(false);
$('password-search-box').focus();
},
@@ -233,6 +248,20 @@ cr.define('options', function() {
setManageAccountLinkVisibility_: function(visible) {
$('manage-passwords-span').hidden = !visible;
},
+
+ /**
+ * @param {boolean} visible Whether the import-password-complete UI should
+ * be visible
+ * @private
+ */
+ setImportCompleteUIVisibility_: function(visible) {
+ var sections = document.querySelectorAll('.password-manager-default');
Garrett Casto 2015/06/23 23:42:35 This seems like it might look a little strange, to
xunlu 2015/06/25 17:12:15 Done.
+ for (var i = 0; i < sections.length; i++)
+ sections[i].hidden = visible;
+ sections = document.querySelectorAll('.import-password-complete');
+ for (var i = 0; i < sections.length; i++)
+ sections[i].hidden = !visible;
+ },
};
/**
@@ -262,7 +291,8 @@ cr.define('options', function() {
'setManageAccountLinkVisibility',
'setSavedPasswordsList',
'setPasswordExceptionsList',
- 'showPassword'
+ 'showPassword',
+ 'setImportCompleteUIVisibility'
]);
// Export

Powered by Google App Engine
This is Rietveld 408576698