components/password_manager/core/browser/import/csv_reader.h - Issue 1193143003: Enable import/export of passwords into/from Password Manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/import/csv_reader.h

Issue 1193143003: Enable import/export of passwords into/from Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix problem revealed through git-cl-try Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/export/password_exporter.cc ('K') | « components/password_manager/core/browser/export/password_exporter_unittest.cc ('k') | components/password_manager/core/browser/import/password_importer.h » ('j') | components/password_manager/core/browser/import/password_importer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/import/csv_reader.h

diff --git a/components/password_manager/core/browser/import/csv_reader.h b/components/password_manager/core/browser/import/csv_reader.h

index b1dcde5d34cf12b11e2d1b51f587501014df11c5..f13b3953aec418d3aaf26109b690d834776a395e 100644

--- a/components/password_manager/core/browser/import/csv_reader.h

+++ b/components/password_manager/core/browser/import/csv_reader.h

@@ -14,6 +14,8 @@

namespace password_manager {

+typedef std::map<std::string, std::string> ColumnNameToValueMap;

Garrett Casto 2015/06/26 21:13:48 For some reason I forgot that this would be used i

xunlu 2015/06/30 23:06:09 Done.

// Reads tabular data from CSV (Comma Separated Values) format as defined in RFC

// 4180, with the following limitations/relaxations:

// * The input should be UTF-8 encoded. No code points should be escaped.