tools/metrics/histograms/histograms.xml - Issue 1193143003: Enable import/export of passwords into/from Password Manager

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1193143003: Enable import/export of passwords into/from Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« components/password_manager/core/browser/import/password_importer_unittest.cc ('K') | « components/password_manager/core/common/password_manager_features.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 82f8b6b664bd059e3a527d4ec1886c86ce9e2f84..5c93ecffbc052333ce22615a60b5c2218c878d6b 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -34076,6 +34076,21 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="PasswordManager.ExportedPasswordsPerUserInCSV">

+ <owner>xunlu@chromium.org</owner>

+ <owner>vabr@chromium.org</owner>

+ <summary>The number of passwords exported in CSV format per user.</summary>

+</histogram>

+<histogram name="PasswordManager.FailToStorePasswordImportedFromCSV">

+ <owner>xunlu@chromium.org</owner>

+ <owner>vabr@chromium.org</owner>

+ <summary>

+ The number of times password manager failed to store passwords imported from

+ a CSV file.

+ </summary>

+</histogram>

<histogram name="PasswordManager.FilledCredentialWasFromAndroidApp"

enum="PasswordManagerFilledAndroidCredentials">

<owner>msramek@chromium.org</owner>

@@ -34117,6 +34132,22 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="PasswordManager.ImportedPasswordsPerUserInCSV">

+ <owner>xunlu@chromium.org</owner>

+ <owner>vabr@chromium.org</owner>

+ <summary>The number of passwords imported in CSV format per user</summary>

+</histogram>

+<histogram name="PasswordManager.ImportPasswordFromCSVResult"

+ enum="PasswordImportFromCSVResult">

+ <owner>xunlu@chromium.org</owner>

+ <owner>vabr@chromium.org</owner>

+ <summary>

+ The response code of successful or failed password import attempt from a CSV

+ file.

+ </summary>

+</histogram>

<owner>vabr@chromium.org</owner>

@@ -76070,6 +76101,22 @@ To add a new entry, add it with any value and run test to compute valid value.

</enum>

+<enum name="PasswordGenerationSubmissionEvent" type="int">

vabr (Chromium) 2016/03/16 17:48:28 Is this enum included by accident?

xunlu 2016/03/18 21:15:30 no idea. Removed.

+ <int value="0" label="Generated password original submission succeeded"/>

+ <int value="1" label="Generated password original submission failed"/>

+ <int value="2" label="Generated password not submitted"/>

+ <int value="3" label="Generated password overridden by a non-generated one"/>

+ <int value="4" label="Generated password used"/>

+</enum>

+<enum name="PasswordImportFromCSVResult" type="int">

+ <int value="0" label="Password import succeeded"/>

+ <int value="1" label="Password import failed due to IO error"/>

+ <int value="2" label="Password import failed due to malformed CSV"/>

+ <int value="3" label="Password import failed due to missing content"/>

+ <int value="4" label="Boundary value"/>

+</enum>

Deprecated as of Chrome 32. See PasswordManagerActionsTakenWithPsl