Enable import/export of passwords into/from Password Manager

chrome/browser/ui/passwords/password_manager_presenter.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/passwords/password_manager_presenter.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/metrics/user_metrics_action.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "base/values.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/password_manager/sync_metrics.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/passwords/manage_passwords_view_utils.h"
 #include "chrome/browser/ui/passwords/password_ui_view.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/password_manager/core/browser/affiliation_utils.h"
+#include "components/password_manager/core/browser/import/password_importer.h"
 #include "components/password_manager/core/browser/password_manager_util.h"
 #include "components/password_manager/core/common/password_manager_pref_names.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 
 using password_manager::PasswordStore;
 
 PasswordManagerPresenter::PasswordManagerPresenter(
     PasswordUIView* password_view)
     : populater_(this),
@@ skipping 81 matching lines @@
     return;
   }
   PasswordStore* store = GetPasswordStore();
   if (!store)
     return;
   store->RemoveLogin(*password_exception_list_[index]);
   content::RecordAction(
       base::UserMetricsAction("PasswordManager_RemovePasswordException"));
 }
 
+bool PasswordManagerPresenter::RequestToExportPassword() {

[vabr (Chromium), 2015/07/07 12:58:05]

This method now adds nothing to calling IsUserAuthenticated() directly (in
particular, the #ifdefs are not necessary, given they also appear in
IsUserAuthenticated). I would suggest making IsUserAuthenticated public and
replacing RequestToExportPassword with IsUserAuthenticated.

[xunlu, 2015/07/07 18:42:47]

Done.

+#if defined(OS_ANDROID)
+  NOTREACHED();
+  return false;
+#else
+  return IsUserAuthenticated();
+#endif
+}
+
 void PasswordManagerPresenter::RequestShowPassword(size_t index) {
-#if !defined(OS_ANDROID) // This is never called on Android.
+#if defined(OS_ANDROID)
+  NOTREACHED();
+#else
   if (index >= password_list_.size()) {
     // |index| out of bounds might come from a compromised renderer, don't let
     // it crash the browser. http://crbug.com/362054
     NOTREACHED();
     return;
   }
-  if (IsAuthenticationRequired()) {
-    if (password_manager_util::AuthenticateUser(
-        password_view_->GetNativeWindow()))
-      last_authentication_time_ = base::TimeTicks::Now();
-    else
-      return;
+
+  if (!IsUserAuthenticated()) {
+    return;
   }
 
   if (password_manager_sync_metrics::IsSyncAccountCredential(
           password_view_->GetProfile(),
           base::UTF16ToUTF8(password_list_[index]->username_value),
           password_list_[index]->signon_realm)) {
     content::RecordAction(
         base::UserMetricsAction("PasswordManager_SyncCredentialShown"));
   }
 
   // Call back the front end to reveal the password.
   std::string origin_url = password_manager::GetHumanReadableOrigin(
       *password_list_[index], languages_);
   password_view_->ShowPassword(
       index,
       origin_url,
       base::UTF16ToUTF8(password_list_[index]->username_value),
       password_list_[index]->password_value);
 #endif
 }
 
+ScopedVector<autofill::PasswordForm>
+PasswordManagerPresenter::GetAllPasswords() {
+  ScopedVector<autofill::PasswordForm> ret_val;
+
+  for (const autofill::PasswordForm* form : password_list_.get()) {
+    ret_val.push_back(new autofill::PasswordForm(*form));
+  }
+
+  return ret_val.Pass();
+}
+
 const autofill::PasswordForm* PasswordManagerPresenter::GetPassword(
     size_t index) {
   if (index >= password_list_.size()) {
     // |index| out of bounds might come from a compromised renderer, don't let
     // it crash the browser. http://crbug.com/362054
     NOTREACHED();
     return NULL;
   }
   return password_list_[index];
 }
@@ skipping 25 matching lines @@
 void PasswordManagerPresenter::SetPasswordExceptionList() {
   password_view_->SetPasswordExceptionList(password_exception_list_);
 }
 
 bool PasswordManagerPresenter::IsAuthenticationRequired() {
   base::TimeDelta delta = base::TimeDelta::FromSeconds(60);
   return require_reauthentication_ &&
       (base::TimeTicks::Now() - last_authentication_time_) > delta;
 }
 
+bool PasswordManagerPresenter::IsUserAuthenticated() {
+#if defined(OS_ANDROID)
+  NOTREACHED();
+  return false;
+#else
+  if (IsAuthenticationRequired()) {
+    if (password_manager_util::AuthenticateUser(
+            password_view_->GetNativeWindow()))
+      last_authentication_time_ = base::TimeTicks::Now();
+    else
+      return false;
+  }
+  return true;
+#endif
+}
+
 PasswordManagerPresenter::ListPopulater::ListPopulater(
     PasswordManagerPresenter* page) : page_(page) {
 }
 
 PasswordManagerPresenter::ListPopulater::~ListPopulater() {
 }
 
 PasswordManagerPresenter::PasswordListPopulater::PasswordListPopulater(
     PasswordManagerPresenter* page) : ListPopulater(page) {
 }
@@ skipping 27 matching lines @@
   } else {
     LOG(ERROR) << "No password store! Cannot display exceptions.";
   }
 }
 
 void PasswordManagerPresenter::PasswordExceptionListPopulater::
     OnGetPasswordStoreResults(ScopedVector<autofill::PasswordForm> results) {
   page_->password_exception_list_.swap(results);
   page_->SetPasswordExceptionList();
 }