Enable import/export of passwords into/from Password Manager

chrome/browser/ui/passwords/password_manager_presenter.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PASSWORDS_PASSWORD_MANAGER_PRESENTER_H_
 #define CHROME_BROWSER_UI_PASSWORDS_PASSWORD_MANAGER_PRESENTER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 25 matching lines @@
       const password_manager::PasswordStoreChangeList& changes) override;
 
   // Repopulates the password and exception entries.
   void UpdatePasswordLists();
 
   void Initialize();
 
   // Gets the password entry at |index|.
   const autofill::PasswordForm* GetPassword(size_t index);
 
+  // Gets all password entries.
+  ScopedVector<autofill::PasswordForm> GetAllPasswords();
+
   // Gets the password exception entry at |index|.
   const autofill::PasswordForm* GetPasswordException(size_t index);
 
   // Removes the saved password entry at |index|.
   // |index| the entry index to be removed.
   void RemoveSavedPassword(size_t index);
 
+  // Add password forms in |forms| to PasswordStore, return true if succeed.

[vabr (Chromium), 2015/07/06 08:57:16]

nit: "if succeed" -> "on success"

[xunlu, 2015/07/07 00:46:03]

Done.

+  virtual bool AddPasswordsToStore(

[vabr (Chromium), 2015/07/06 08:57:16]

There is something fishy about this method -- it does not use anything from the
presenter itself, only gets access to the password store through it. I don't
think this should be part of the presenter logic. My suggestion is to transfer
the for-loop with AddLogin() calls to the handler, and either use
PasswordStoreFactory::GetForProfile() to get the store pointer there, or if
that's not possible, just make the presenter's GetPasswordStore() public and use
it in the handler.

[xunlu, 2015/07/07 00:46:03]

Done.

+      const std::vector<autofill::PasswordForm>& forms);
+
   // Removes the saved password exception entry at |index|.
   // |index| the entry index to be removed.
   void RemovePasswordException(size_t index);
 
   // Requests the plain text password for entry at |index| to be revealed.
   // |index| The index of the entry.
   void RequestShowPassword(size_t index);
 
+  // Request passwords in |password_list_| to be exported. Return true if

[vabr (Chromium), 2015/07/06 08:57:16]

nit: Could you please make it clearer who/what decides to grant the request or
not? Is it the user? Or some automated criterion? 

Also, is |password_list_| the same as "all password entries" referred with
GetAllPasswords above? If so, then we should be consistent and only use "all
password entries" in both cases. (Also note that referencing implementation
details like data members in public API description may cause issues for
readability and staying up to date.)

[xunlu, 2015/07/07 00:46:03]

Done.

+  // request granted.
+  virtual bool RequestToExportPassword();
+
  private:
   friend class PasswordManagerPresenterTest;
 
   // Returns the password store associated with the currently active profile.
   password_manager::PasswordStore* GetPasswordStore();
 
   // Returns true if the user needs to be authenticated before a plaintext
   // password is revealed.
   bool IsAuthenticationRequired();
 
@@ skipping 61 matching lines @@
   // UI view that owns this presenter.
   PasswordUIView* password_view_;
 
   // User pref for storing accept languages.
   std::string languages_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordManagerPresenter);
 };
 
 #endif  // CHROME_BROWSER_UI_PASSWORDS_PASSWORD_MANAGER_PRESENTER_H_