Enable import/export of passwords into/from Password Manager

chrome/browser/ui/passwords/password_manager_presenter.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/passwords/password_manager_presenter.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/metrics/user_metrics_action.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "base/values.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/password_manager/sync_metrics.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/passwords/manage_passwords_view_utils.h"
 #include "chrome/browser/ui/passwords/password_ui_view.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/password_manager/core/browser/affiliation_utils.h"
+#include "components/password_manager/core/browser/import/password_importer.h"
 #include "components/password_manager/core/browser/password_manager_util.h"
 #include "components/password_manager/core/common/password_manager_pref_names.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 
 using password_manager::PasswordStore;
 
 PasswordManagerPresenter::PasswordManagerPresenter(
     PasswordUIView* password_view)
     : populater_(this),
@@ skipping 81 matching lines @@
     return;
   }
   PasswordStore* store = GetPasswordStore();
   if (!store)
     return;
   store->RemoveLogin(*password_exception_list_[index]);
   content::RecordAction(
       base::UserMetricsAction("PasswordManager_RemovePasswordException"));
 }
 
+bool PasswordManagerPresenter::AddPasswordsToStore(
+    const std::vector<autofill::PasswordForm>& forms) {
+  PasswordStore* store = GetPasswordStore();
+  if (!store)
+    return false;
+
+  for (std::vector<autofill::PasswordForm>::const_iterator it = forms.begin();

[vabr (Chromium), 2015/07/06 08:57:15]

optional nit:
for (const autofill::PasswordForm* form : forms) {...}

[xunlu, 2015/07/07 00:46:03]

Done.

+       it != forms.end(); ++it) {
+    store->AddLogin(*it);
+  }
+  return true;
+}
+
+bool PasswordManagerPresenter::RequestToExportPassword() {
+#if !defined(OS_ANDROID)  // This is never called on Android.

[vabr (Chromium), 2015/07/06 08:57:15]

Instead of the comment, I suggest the self-documenting NOTREACHED():

#if defined(OS_ANDROID)
  NOTREACHED();
  return false;
#else
  ...

[xunlu, 2015/07/07 00:46:03]

Done.

+  if (IsAuthenticationRequired()) {

[vabr (Chromium), 2015/07/06 08:57:15]

I suggest to pull out lines 141-147 as a separate private method and reuse it
here and in RequestShowPassword() instead of duplicating the code. The main
benefit is making sure that we are always consistent with how we ask for reauth.

[xunlu, 2015/07/07 00:46:03]

Done.

+    if (password_manager_util::AuthenticateUser(
+            password_view_->GetNativeWindow()))
+      last_authentication_time_ = base::TimeTicks::Now();
+    else
+      return false;
+  }
+#endif
+  return true;

[vabr (Chromium), 2015/07/06 08:57:16]

Please move the "return true;" to the !defined(OS_ANDROID) block. This should
not be a "fall-back option", it is only meant as an answer to no authentication
required. The behaviour for OS_ANDROID should be defined in a separate #if
clause with NOTREACHED, as indicated in my comment above.

[xunlu, 2015/07/07 00:46:03]

Done.

+}
+
 void PasswordManagerPresenter::RequestShowPassword(size_t index) {
 #if !defined(OS_ANDROID) // This is never called on Android.
   if (index >= password_list_.size()) {
     // |index| out of bounds might come from a compromised renderer, don't let
     // it crash the browser. http://crbug.com/362054
     NOTREACHED();
     return;
   }
   if (IsAuthenticationRequired()) {
     if (password_manager_util::AuthenticateUser(
@@ skipping 15 matching lines @@
   std::string origin_url = password_manager::GetHumanReadableOrigin(
       *password_list_[index], languages_);
   password_view_->ShowPassword(
       index,
       origin_url,
       base::UTF16ToUTF8(password_list_[index]->username_value),
       password_list_[index]->password_value);
 #endif
 }
 
+ScopedVector<autofill::PasswordForm>
+PasswordManagerPresenter::GetAllPasswords() {
+  ScopedVector<autofill::PasswordForm> retVal;

[vabr (Chromium), 2015/07/06 08:57:16]

nit: ret_val, not retVal
(See
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Variable_Names.)

[xunlu, 2015/07/07 00:46:03]

Done.

+
+  for (ScopedVector<autofill::PasswordForm>::const_iterator it =

[vabr (Chromium), 2015/07/06 08:57:15]

optional nit:
for (const autofill::PasswordForm* entry : password_list_) {...}

[xunlu, 2015/07/07 00:46:03]

Done.

+           password_list_.begin();
+       it != password_list_.end(); ++it) {
+    retVal.push_back(new autofill::PasswordForm(**it));
+  }
+
+  return retVal.Pass();
+}
+
 const autofill::PasswordForm* PasswordManagerPresenter::GetPassword(
     size_t index) {
   if (index >= password_list_.size()) {
     // |index| out of bounds might come from a compromised renderer, don't let
     // it crash the browser. http://crbug.com/362054
     NOTREACHED();
     return NULL;
   }
   return password_list_[index];
 }
@@ skipping 72 matching lines @@
   } else {
     LOG(ERROR) << "No password store! Cannot display exceptions.";
   }
 }
 
 void PasswordManagerPresenter::PasswordExceptionListPopulater::
     OnGetPasswordStoreResults(ScopedVector<autofill::PasswordForm> results) {
   page_->password_exception_list_.swap(results);
   page_->SetPasswordExceptionList();
 }