Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1193113004: Revert of Android: Store language .pak files in res/raw rather than assets (Closed)

Created:
5 years, 6 months ago by qinmin
Modified:
5 years, 6 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mkwst+moarreviews-shell_chromium.org, lcwu+watch_chromium.org, jam, android-webview-reviews_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, gunsch+watch_chromium.org, klundberg+watch_chromium.org, erikwright+watch_chromium.org, jbudorick+watch_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@load-from-apk-v8
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Android: Store language .pak files in res/raw rather than assets (patchset #7 id:120001 of https://codereview.chromium.org/1158053005/) Reason for revert: this change breaks android TOT bot Original issue's description: > Android: Store language .pak files in res/raw rather than assets > > This is a prerequisite for having them live within APK splits. > > Although pak files need to be renamed to be stored under res/raw, > ResourceExtractor restores their original name during extraction (so no > change to native code). > > All sub-locales are stored and extracted together, just as before. > > BUG=371610 > > Committed: https://crrev.com/f30e04470453ccd7e6a9abf586185b991d174902 > Cr-Commit-Position: refs/heads/master@{#335350} TBR=yfriedman@chromium.org,torne@chromium.org,cjhopman@chromium.org,jaekyun@chromium.org,jhawkins@chromium.org,gunsch@chromium.org,newt@chromium.org,agrieve@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=371610

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -346 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java View 1 chunk +2 lines, -1 line 0 comments Download
M base/android/java/src/org/chromium/base/ResourceExtractor.java View 9 chunks +127 lines, -96 lines 0 comments Download
D build/android/gyp/locale_pak_resources.py View 1 chunk +0 lines, -97 lines 0 comments Download
D build/android/locale_pak_resources.gypi View 1 chunk +0 lines, -52 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +0 lines, -57 lines 0 comments Download
M chrome/android/BUILD.gn View 4 chunks +9 lines, -16 lines 0 comments Download
M chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeMobileApplication.java View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/chrome_android_paks.gypi View 2 chunks +44 lines, -2 lines 0 comments Download
M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java View 1 chunk +1 line, -1 line 0 comments Download
M components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
qinmin
Created Revert of Android: Store language .pak files in res/raw rather than assets
5 years, 6 months ago (2015-06-20 02:53:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193113004/1
5 years, 6 months ago (2015-06-20 02:53:50 UTC) #2
commit-bot: I haz the power
Failed to apply patch for build/config/android/rules.gni: While running git apply --index -3 -p1; error: patch ...
5 years, 6 months ago (2015-06-20 02:54:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193113004/1
5 years, 6 months ago (2015-06-20 02:55:40 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-20 03:00:37 UTC) #8
Failed to apply patch for build/config/android/rules.gni:
While running git apply --index -3 -p1;
  error: patch failed: build/config/android/rules.gni:540
  Falling back to three-way merge...
  Applied patch to 'build/config/android/rules.gni' with conflicts.
  U build/config/android/rules.gni

Patch:       build/config/android/rules.gni
Index: build/config/android/rules.gni
diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
index
96cbe44f1ca6d5a8ddd2d78217e4f6ab2360c15b..4c22fac76814df3c0aeaa14a54d096b755c238a2
100644
--- a/build/config/android/rules.gni
+++ b/build/config/android/rules.gni
@@ -540,63 +540,6 @@
     deps = [
       ":${target_name}__build_config",
       ":${target_name}__template",
-    ]
-  }
-}
-
-# Creates a resources.zip with locale.pak files placed into appropriate
-# resource configs (e.g. en-GB.pak -> res/raw-en/en_gb.pak). Also generates
-# a locale_paks TypedArray so that resource files can be enumerated at runtime.
-#
-# If this target is included in the deps of an android resources/library/apk,
-# the resources will be included with that target.
-#
-# Variables:
-#   sources: List of .pak files. Names must be of the form "en.pak" or
-#       "en-US.pak".
-#
-# Example
-#   locale_pak_resources("locale_paks") {
-#     sources = [ "path/en-US.pak", "path/fr.pak", ... ]
-#   }
-template("locale_pak_resources") {
-  set_sources_assignment_filter([])
-  assert(defined(invoker.sources))
-
-  _base_path = "$target_gen_dir/$target_name"
-  _resources_zip = _base_path + ".resources.zip"
-  _build_config = _base_path + ".build_config"
-
-  write_build_config("${target_name}__build_config") {
-    build_config = _build_config
-    resources_zip = _resources_zip
-    type = "android_resources"
-  }
-
-  action("${target_name}__create_resources_zip") {
-    sources = invoker.sources
-    script = "//build/android/gyp/locale_pak_resources.py"
-    depfile = "$target_gen_dir/$target_name.d"
-
-    outputs = [
-      depfile,
-      _resources_zip,
-    ]
-
-    _rebased_sources = rebase_path(invoker.sources, root_build_dir)
-    args = [
-      "--locale-paks=${_rebased_sources}",
-      "--resources-zip",
-      rebase_path(_resources_zip, root_build_dir),
-      "--depfile",
-      rebase_path(depfile, root_build_dir),
-    ]
-  }
-
-  group(target_name) {
-    deps = [
-      ":${target_name}__build_config",
-      ":${target_name}__create_resources_zip",
     ]
   }
 }

Powered by Google App Engine
This is Rietveld 408576698