adds file path source to pub

utils/pub/validator/dependency.dart

-// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dependency_validator;
 
 import 'dart:async';
 
 import '../entrypoint.dart';
 import '../hosted_source.dart';
+import '../path_source.dart';
 import '../http.dart';
 import '../package.dart';
 import '../utils.dart';
 import '../validator.dart';
 import '../version.dart';
 
 /// A validator that validates a package's dependencies.
 class DependencyValidator extends Validator {
   DependencyValidator(Entrypoint entrypoint)
     : super(entrypoint);
 
   Future validate() {
-    return Future.forEach(entrypoint.root.pubspec.dependencies, (dependency) {
+    return Futures.forEach(entrypoint.root.pubspec.dependencies, (dependency) {
+      if (dependency.source is PathSource){
+        errors.add('"${dependency.name}" dependancy package must be defined '
+            'using "hosted" or "git" source.');
+            return new Future.immediate(null);
+      }

[Bob Nystrom, 2013/01/17 19:15:10]

Let's reuse the _warnAboutSource method here since it generates a nice error
message. How about changing it to:

_reportInvalidSource(PackageRef ref, {bool error = false}) { ... }

Then in the body check "error" to see if it should be reported to errors or
warnings.

[Sam E, 2013/01/20 04:16:57]

I don't think this is going to work. The logic is completely different when
using a path source.

I'll leave it as is for now

       if (dependency.source is! HostedSource) {
         return _warnAboutSource(dependency);
       }
 
       if (dependency.name == entrypoint.root.name) {
         warnings.add('You don\'t need to explicitly depend on your own '
                 'package.\n'
             'Pub enables "package:${entrypoint.root.name}" imports '
                 'implicitly.');
         return new Future.immediate(null);
@@ skipping 58 matching lines @@
   }
 
   /// Returns the suggested version constraint for a dependency that was tested
   /// against [version].
   String _constraintForVersion(Version version) {
     if (version.major != 0) return '">=$version <${version.major + 1}.0.0"';
     return '">=$version <${version.major}.${version.minor}.'
         '${version.patch + 1}"';
   }
 }