Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/x64/macro-assembler-x64.cc

Issue 11931037: Out of bounds memory access in TestJSArrayForAllocationSiteInfo. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Comments from Ulan Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/macro-assembler-mips.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4597 matching lines...) Expand 10 before | Expand all | Expand 10 after
4608 Register receiver_reg, 4608 Register receiver_reg,
4609 Register scratch_reg, 4609 Register scratch_reg,
4610 Label* allocation_info_present) { 4610 Label* allocation_info_present) {
4611 Label no_info_available; 4611 Label no_info_available;
4612 ExternalReference new_space_start = 4612 ExternalReference new_space_start =
4613 ExternalReference::new_space_start(isolate()); 4613 ExternalReference::new_space_start(isolate());
4614 ExternalReference new_space_allocation_top = 4614 ExternalReference new_space_allocation_top =
4615 ExternalReference::new_space_allocation_top_address(isolate()); 4615 ExternalReference::new_space_allocation_top_address(isolate());
4616 4616
4617 lea(scratch_reg, Operand(receiver_reg, 4617 lea(scratch_reg, Operand(receiver_reg,
4618 JSArray::kSize + AllocationSiteInfo::kSize)); 4618 JSArray::kSize + AllocationSiteInfo::kSize - kHeapObjectTag));
4619 movq(kScratchRegister, new_space_start); 4619 movq(kScratchRegister, new_space_start);
4620 cmpq(scratch_reg, kScratchRegister); 4620 cmpq(scratch_reg, kScratchRegister);
4621 j(less, &no_info_available); 4621 j(less, &no_info_available);
4622 cmpq(scratch_reg, ExternalOperand(new_space_allocation_top)); 4622 cmpq(scratch_reg, ExternalOperand(new_space_allocation_top));
4623 j(greater_equal, &no_info_available); 4623 j(greater, &no_info_available);
4624 CompareRoot(MemOperand(scratch_reg, 0), 4624 CompareRoot(MemOperand(scratch_reg, -AllocationSiteInfo::kSize),
4625 Heap::kAllocationSiteInfoMapRootIndex); 4625 Heap::kAllocationSiteInfoMapRootIndex);
4626 j(equal, allocation_info_present); 4626 j(equal, allocation_info_present);
4627 bind(&no_info_available); 4627 bind(&no_info_available);
4628 } 4628 }
4629 4629
4630 4630
4631 } } // namespace v8::internal 4631 } } // namespace v8::internal
4632 4632
4633 #endif // V8_TARGET_ARCH_X64 4633 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/macro-assembler-mips.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698