Issue 1193103005: Subzero: Apply commutativity to the RMW optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1193103005: Subzero: Apply commutativity to the RMW optimization. (Closed)

Created:
5 years, 6 months ago by Jim Stichnoth

Modified:
5 years, 6 months ago

Reviewers:
jvoung (off chromium), mtrofin, Karl, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero: Apply commutativity to the RMW optimization. The read-modify-write (RMW) optimization looks for patterns like this: a = Load addr b = <op> a, other Store b, addr and essentially transforms them into this: RMW <op>, addr, other This CL also applies the transformation when the middle instruction is b = <op> other, a and <op> is commutative. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4095 R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=8525c3297fbf841e6c48ebd2af10f5d9ef66848b

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -6 lines)			Patch
	M	src/IceTargetLoweringX8632.cpp	View	1	2 chunks	+8 lines, -6 lines	0 comments	Download
	M	tests_lit/llvm2ice_tests/rmw.ll	View		1 chunk	+28 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

Jim Stichnoth

This captures a few dozen more opportunities (some even in hot code) across spec2k.

5 years, 6 months ago (2015-06-22 13:45:32 UTC) #3

Jim Stichnoth

5 years, 6 months ago (2015-06-22 17:36:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
8525c3297fbf841e6c48ebd2af10f5d9ef66848b (presubmit successful).