Issue 11931026: Revert 177087.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11931026: Revert 177087. (Closed)

Created:
7 years, 11 months ago by agable

Modified:
7 years, 11 months ago

Reviewers:
dtu

CC:
chromium-reviews, chrome-speed-team+watch_google.com, pam+watch_chromium.org, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 177087. This change appears to have broken many perf bots. See bug at https://code.google.com/p/chromium/issues/detail?id=170310. > [Telemetry] Clean separation between tab (public API) and tab_backend (Chrome implementation). Flatten tab's public methods. > > E.g. instead of tab.page.Navigate('url') it's now tab.Navigate('url'). This makes more sense for other browsers, who won't have the same domain divisions that Chrome DevTools does; and paves the way for future organization/separation between public API and backends. > > BUG=None. > TEST=None. > > Review URL: https://codereview.chromium.org/11819018 TBR=dtu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177225

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+204 lines, -453 lines)			Patch
M	tools/telemetry/telemetry/browser_backend.py	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	tools/telemetry/telemetry/inspector_console.py	View	3 chunks	+8 lines, -8 lines	0 comments	Download
M	tools/telemetry/telemetry/inspector_console_unittest.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/inspector_page.py	View	4 chunks	+67 lines, -8 lines	0 comments	Download
M	tools/telemetry/telemetry/inspector_page_unittest.py	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	tools/telemetry/telemetry/inspector_runtime.py	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	tools/telemetry/telemetry/inspector_timeline.py	View	4 chunks	+10 lines, -9 lines	0 comments	Download
M	tools/telemetry/telemetry/page_runner.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/tab.py	View	3 chunks	+87 lines, -94 lines	0 comments	Download
D	tools/telemetry/telemetry/tab_backend.py	View	1 chunk	+0 lines, -298 lines	0 comments	Download
M	tools/telemetry/telemetry/tab_test_case.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/tab_unittest.py	View	3 chunks	+1 line, -25 lines	0 comments	Download

Total messages: 1 (0 generated)