Removed static factories for data, ftp, file, and about jobs.

net/url_request/ftp_protocol_handler.h

Index: net/url_request/ftp_protocol_handler.h
diff --git a/net/url_request/ftp_protocol_handler.h b/net/url_request/ftp_protocol_handler.h
index 871f42205ebc434335f51d2ed784e1514a48763a..e9f6098fa49e53c63ab2f10c32708ab8c680ab44 100644
--- a/net/url_request/ftp_protocol_handler.h
+++ b/net/url_request/ftp_protocol_handler.h
@@ -7,11 +7,11 @@
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
+#include "net/ftp/ftp_auth_cache.h"
 #include "net/url_request/url_request_job_factory.h"
 
 namespace net {
 
-class FtpAuthCache;
 class FtpTransactionFactory;
 class NetworkDelegate;
 class URLRequestJob;
@@ -20,14 +20,15 @@ class URLRequestJob;
 class NET_EXPORT FtpProtocolHandler :
     public URLRequestJobFactory::ProtocolHandler {
  public:
-  FtpProtocolHandler(FtpTransactionFactory* ftp_transaction_factory,
-                     FtpAuthCache* ftp_auth_cache);
+  explicit FtpProtocolHandler(FtpTransactionFactory* ftp_transaction_factory);
   virtual URLRequestJob* MaybeCreateJob(
       URLRequest* request, NetworkDelegate* network_delegate) const OVERRIDE;
 
  private:
+  friend class FtpTestURLRequestContext;
+
   FtpTransactionFactory* ftp_transaction_factory_;
-  FtpAuthCache* ftp_auth_cache_;
+  mutable FtpAuthCache ftp_auth_cache_;

[Paweł Hajdan Jr., 2013/04/29 18:45:26]

This seems wrong. If MaybeCreateJob is supposed to be const, this looks like
cheating.

Note that it's fine to use mutable for things _unrelated_ to the abstraction
like some bookkeeping/debugging/logging etc. However, FtpAuthCache is definitely
related to the core of what is going on here.

 
   DISALLOW_COPY_AND_ASSIGN(FtpProtocolHandler);
 };