Removed static factories for data, ftp, file, and about jobs.

net/url_request/url_request_job_factory.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_JOB_FACTORY_H_
 #define NET_URL_REQUEST_URL_REQUEST_JOB_FACTORY_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 12 matching lines @@
 class NET_EXPORT URLRequestJobFactory
     : NON_EXPORTED_BASE(public base::NonThreadSafe) {
  public:
   // TODO(shalev): Move this to URLRequestJobFactoryImpl.
   class NET_EXPORT ProtocolHandler {
    public:
     virtual ~ProtocolHandler();
 
     virtual URLRequestJob* MaybeCreateJob(
         URLRequest* request, NetworkDelegate* network_delegate) const = 0;
+
+    // Indicates if it should be safe to redirect to |location|. Should handle
+    // protocols handled by MaybeCreateJob().

[mmenke, 2013/02/19 17:26:15]

This comment is not correct.  As-is, it sounds like if we have a
ProtocolInterceptJobFactory, then its IsSafeRedirectTarget function is checked
for the jobs it creates.

Instead, we only call it for the single protocol it's the official handler for.

[pauljensen, 2013/02/20 15:13:27]

I adjusted the comment to be more correct.  We can remove the extra part of the
comment when we have ProtocolInterceptJobFactory::InterceptHandler.

+    // NOTE(pauljensen): Default implementation returns true.
+    virtual bool IsSafeRedirectTarget(const GURL& location) const;
   };
 
   URLRequestJobFactory();
   virtual ~URLRequestJobFactory();
 
   virtual URLRequestJob* MaybeCreateJobWithProtocolHandler(
       const std::string& scheme,
       URLRequest* request,
       NetworkDelegate* network_delegate) const = 0;
 
   virtual bool IsHandledProtocol(const std::string& scheme) const = 0;
 
   virtual bool IsHandledURL(const GURL& url) const = 0;
 
+  virtual bool IsSafeRedirectTarget(const GURL& location) const = 0;
+
  private:
   DISALLOW_COPY_AND_ASSIGN(URLRequestJobFactory);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_JOB_FACTORY_H_