Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: net/url_request/url_request_ftp_job.h

Issue 11931024: Removed static factories for data, ftp, file, and about jobs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add test for IsSafeRedirectTarget Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_ 5 #ifndef NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_
6 #define NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_ 6 #define NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
(...skipping 14 matching lines...) Expand all
25 25
26 // A URLRequestJob subclass that is built on top of FtpTransaction. It 26 // A URLRequestJob subclass that is built on top of FtpTransaction. It
27 // provides an implementation for FTP. 27 // provides an implementation for FTP.
28 class URLRequestFtpJob : public URLRequestJob { 28 class URLRequestFtpJob : public URLRequestJob {
29 public: 29 public:
30 URLRequestFtpJob(URLRequest* request, 30 URLRequestFtpJob(URLRequest* request,
31 NetworkDelegate* network_delegate, 31 NetworkDelegate* network_delegate,
32 FtpTransactionFactory* ftp_transaction_factory, 32 FtpTransactionFactory* ftp_transaction_factory,
33 FtpAuthCache* ftp_auth_cache); 33 FtpAuthCache* ftp_auth_cache);
34 34
35 // TODO(shalev): get rid of this function in favor of FtpProtocolHandler.
36 static URLRequestJob* Factory(URLRequest* request,
37 NetworkDelegate* network_delegate,
38 const std::string& scheme);
39
40 // Overridden from URLRequestJob: 35 // Overridden from URLRequestJob:
41 virtual bool IsSafeRedirect(const GURL& location) OVERRIDE; 36 virtual bool IsSafeRedirect(const GURL& location) OVERRIDE;
42 virtual bool GetMimeType(std::string* mime_type) const OVERRIDE; 37 virtual bool GetMimeType(std::string* mime_type) const OVERRIDE;
43 virtual void GetResponseInfo(HttpResponseInfo* info) OVERRIDE; 38 virtual void GetResponseInfo(HttpResponseInfo* info) OVERRIDE;
44 virtual HostPortPair GetSocketAddress() const OVERRIDE; 39 virtual HostPortPair GetSocketAddress() const OVERRIDE;
45 40
46 private: 41 private:
47 virtual ~URLRequestFtpJob(); 42 virtual ~URLRequestFtpJob();
48 43
49 void OnResolveProxyComplete(int result); 44 void OnResolveProxyComplete(int result);
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 88
94 FtpTransactionFactory* ftp_transaction_factory_; 89 FtpTransactionFactory* ftp_transaction_factory_;
95 FtpAuthCache* ftp_auth_cache_; 90 FtpAuthCache* ftp_auth_cache_;
96 91
97 DISALLOW_COPY_AND_ASSIGN(URLRequestFtpJob); 92 DISALLOW_COPY_AND_ASSIGN(URLRequestFtpJob);
98 }; 93 };
99 94
100 } // namespace net 95 } // namespace net
101 96
102 #endif // NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_ 97 #endif // NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698