Removed static factories for data, ftp, file, and about jobs.

net/url_request/protocol_intercept_job_factory.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_PROTOCOL_INTERCEPT_JOB_FACTORY_H_
 #define NET_URL_REQUEST_PROTOCOL_INTERCEPT_JOB_FACTORY_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "net/base/net_export.h"
 #include "net/url_request/url_request_job_factory.h"
 
 class GURL;
 
 namespace net {
 
 class URLRequest;
 class URLRequestJob;
 
 // This class acts as a wrapper for URLRequestJobFactory. |protocol_handler_| is
 // given the option of creating a URLRequestJob for each potential URLRequest.
 // If |protocol_handler_| does not create a job (i.e. MaybeCreateJob() returns
 // NULL) the URLRequest is forwarded to the |job_factory_| to be handled there.

[mmenke, 2013/02/19 17:26:15]

I think we should mention that only the ProtocolHandler's MaybeCreateJob
function is called - None of its Is* functions is called.

May even want a separate class for this (In another CL), to make this clear.  I
don't think there's any ProtocolHandler used both as an interceptor and as a
full ProtocolHandler, though I could be wrong.

[pauljensen, 2013/02/20 15:13:27]

Done.
You are correct.  I agree; I think we should create
ProtocolInterceptorJobFactory::InterceptHandler which has only a
MaybeCreateJob() pure virtual method.

[mmenke, 2013/02/20 15:48:58]

SGTM

 class NET_EXPORT ProtocolInterceptJobFactory : public URLRequestJobFactory {
  public:
   ProtocolInterceptJobFactory(scoped_ptr<URLRequestJobFactory> job_factory,
                               scoped_ptr<ProtocolHandler> protocol_handler);
   virtual ~ProtocolInterceptJobFactory();
 
   // URLRequestJobFactory implementation
   virtual URLRequestJob* MaybeCreateJobWithProtocolHandler(
       const std::string& scheme,
       URLRequest* request,
       NetworkDelegate* network_delegate) const OVERRIDE;
   virtual bool IsHandledProtocol(const std::string& scheme) const OVERRIDE;
   virtual bool IsHandledURL(const GURL& url) const OVERRIDE;
+  virtual bool IsSafeRedirectTarget(const GURL& location) const OVERRIDE;
 
  private:
   scoped_ptr<URLRequestJobFactory> job_factory_;
   scoped_ptr<ProtocolHandler> protocol_handler_;
 
   DISALLOW_COPY_AND_ASSIGN(ProtocolInterceptJobFactory);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_PROTOCOL_INTERCEPT_JOB_FACTORY_H_