Removed static factories for data, ftp, file, and about jobs.

chrome/browser/profiles/profile_io_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_io_data.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 315 matching lines @@
 // static
 ProfileIOData* ProfileIOData::FromResourceContext(
     content::ResourceContext* rc) {
   return (static_cast<ResourceContext*>(rc))->io_data_;
 }
 
 // static
 bool ProfileIOData::IsHandledProtocol(const std::string& scheme) {
   DCHECK_EQ(scheme, StringToLowerASCII(scheme));
   static const char* const kProtocolList[] = {
+    chrome::kFileScheme,
+    chrome::kChromeDevToolsScheme,

[mmenke, 2013/01/22 16:50:37]

Why change the order of this and kExtensionResourceScheme?

[pauljensen, 2013/01/23 21:43:33]

To better match ProfileIOData::SetUpJobFactoryDefaults (which has the comment
that this function should stay in sync).  This makes it easier to keep this list
in sync.

     extensions::kExtensionScheme,
+    chrome::kExtensionResourceScheme,
     chrome::kChromeUIScheme,
-    chrome::kChromeDevToolsScheme,
+    chrome::kDataScheme,
 #if defined(OS_CHROMEOS)
-    chrome::kMetadataScheme,

[mmenke, 2013/01/22 16:50:37]

Why are you removing this?

[pauljensen, 2013/01/23 21:43:33]

It was added in r85556 along with the ProtocolHandler, but the ProtocolHandler
was later removed in r90962 but the entry here was never removed.  I was
removing it so as to stay in sync.

     chrome::kDriveScheme,
 #endif  // defined(OS_CHROMEOS)
+    chrome::kAboutScheme,
+#if !defined(DISABLE_FTP_SUPPORT)
+    chrome::kFtpScheme,
+#endif  // !defined(DISABLE_FTP_SUPPORT)
     chrome::kBlobScheme,
-    chrome::kFileSystemScheme,
-    chrome::kExtensionResourceScheme,
+    chrome::kFileSystemScheme
   };
   for (size_t i = 0; i < arraysize(kProtocolList); ++i) {
     if (scheme == kProtocolList[i])
       return true;
   }
   return net::URLRequest::IsHandledProtocol(scheme);
 }
 
 bool ProfileIOData::IsHandledURL(const GURL& url) {
   if (!url.is_valid()) {
@@ skipping 249 matching lines @@
   context->set_http_user_agent_settings(
       chrome_http_user_agent_settings_.get());
   context->set_ssl_config_service(profile_params_->ssl_config_service);
 }
 
 scoped_ptr<net::URLRequestJobFactory> ProfileIOData::SetUpJobFactoryDefaults(
     scoped_ptr<net::URLRequestJobFactoryImpl> job_factory,
     scoped_ptr<ProtocolHandlerRegistry::JobInterceptorFactory>
         protocol_handler_interceptor,
     net::NetworkDelegate* network_delegate,
-    net::FtpTransactionFactory* ftp_transaction_factory,
-    net::FtpAuthCache* ftp_auth_cache) const {
+    net::FtpTransactionFactory* ftp_transaction_factory) const {
   // NOTE(willchan): Keep these protocol handlers in sync with
   // ProfileIOData::IsHandledProtocol().
   bool set_protocol = job_factory->SetProtocolHandler(
       chrome::kFileScheme, new net::FileProtocolHandler());
   DCHECK(set_protocol);
 
   set_protocol = job_factory->SetProtocolHandler(
       chrome::kChromeDevToolsScheme,
       CreateDevToolsProtocolHandler(chrome_url_data_manager_backend(),
                                     network_delegate, is_incognito()));
@@ skipping 24 matching lines @@
   }
 #endif  // defined(OS_CHROMEOS)
 
   job_factory->SetProtocolHandler(
       chrome::kAboutScheme,
       new chrome_browser_net::AboutProtocolHandler());
 #if !defined(DISABLE_FTP_SUPPORT)
   DCHECK(ftp_transaction_factory);
   job_factory->SetProtocolHandler(
       chrome::kFtpScheme,
-      new net::FtpProtocolHandler(ftp_transaction_factory,
-                                  ftp_auth_cache));
+      new net::FtpProtocolHandler(ftp_transaction_factory));
 #endif  // !defined(DISABLE_FTP_SUPPORT)
 
   if (protocol_handler_interceptor) {
     protocol_handler_interceptor->Chain(
         job_factory.PassAs<net::URLRequestJobFactory>());
     return protocol_handler_interceptor.PassAs<net::URLRequestJobFactory>();
   } else {
     return job_factory.PassAs<net::URLRequestJobFactory>();
   }
 }
@@ skipping 64 matching lines @@
 void ProfileIOData::SetCookieSettingsForTesting(
     CookieSettings* cookie_settings) {
   DCHECK(!cookie_settings_.get());
   cookie_settings_ = cookie_settings;
 }
 
 void ProfileIOData::set_signin_names_for_testing(
     SigninNamesOnIOThread* signin_names) {
   signin_names_.reset(signin_names);
 }