Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: net/url_request/ftp_protocol_handler.h

Issue 11931024: Removed static factories for data, ftp, file, and about jobs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address phajdan.jr's comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_URL_REQUEST_FTP_PROTOCOL_HANDLER_H_ 5 #ifndef NET_URL_REQUEST_FTP_PROTOCOL_HANDLER_H_
6 #define NET_URL_REQUEST_FTP_PROTOCOL_HANDLER_H_ 6 #define NET_URL_REQUEST_FTP_PROTOCOL_HANDLER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/memory/scoped_ptr.h"
10 #include "net/url_request/url_request_job_factory.h" 11 #include "net/url_request/url_request_job_factory.h"
11 12
12 namespace net { 13 namespace net {
13 14
14 class FtpAuthCache; 15 class FtpAuthCache;
15 class FtpTransactionFactory; 16 class FtpTransactionFactory;
16 class NetworkDelegate; 17 class NetworkDelegate;
17 class URLRequestJob; 18 class URLRequestJob;
18 19
19 // Implements a ProtocolHandler for FTP. 20 // Implements a ProtocolHandler for FTP.
20 class NET_EXPORT FtpProtocolHandler : 21 class NET_EXPORT FtpProtocolHandler :
21 public URLRequestJobFactory::ProtocolHandler { 22 public URLRequestJobFactory::ProtocolHandler {
22 public: 23 public:
23 FtpProtocolHandler(FtpTransactionFactory* ftp_transaction_factory, 24 explicit FtpProtocolHandler(FtpTransactionFactory* ftp_transaction_factory);
24 FtpAuthCache* ftp_auth_cache);
25 virtual URLRequestJob* MaybeCreateJob( 25 virtual URLRequestJob* MaybeCreateJob(
26 URLRequest* request, NetworkDelegate* network_delegate) const OVERRIDE; 26 URLRequest* request, NetworkDelegate* network_delegate) const OVERRIDE;
27 27
28 private: 28 private:
29 friend class FtpTestURLRequestContext;
30
29 FtpTransactionFactory* ftp_transaction_factory_; 31 FtpTransactionFactory* ftp_transaction_factory_;
30 FtpAuthCache* ftp_auth_cache_; 32 scoped_ptr<FtpAuthCache> ftp_auth_cache_;
31 33
32 DISALLOW_COPY_AND_ASSIGN(FtpProtocolHandler); 34 DISALLOW_COPY_AND_ASSIGN(FtpProtocolHandler);
33 }; 35 };
34 36
35 } // namespace net 37 } // namespace net
36 38
37 #endif // NET_URL_REQUEST_FTP_PROTOCOL_HANDLER_H_ 39 #endif // NET_URL_REQUEST_FTP_PROTOCOL_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698