Issue 11931012: Fix arguments materialization for inlined apply().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11931012: Fix arguments materialization for inlined apply(). (Closed)

Created:
7 years, 11 months ago by Michael Starzinger

Modified:
7 years, 11 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix arguments materialization for inlined apply(). This fixes materialization of the arguments object in case the constant function check if TryCallApply() inside an inlined frame fails. R=svenpanne@chromium.org BUG=v8:2489 TEST=mjsunit/regress/regress-2489 Committed: http://code.google.com/p/v8/source/detail?r=13386

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -14 lines)			Patch
M	src/hydrogen.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/hydrogen-instructions.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
A +	test/mjsunit/regress/regress-2489.js	View	2 chunks	+16 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages