Add force_compositing_mode support in gpu blacklist.

Add force_compositing_mode support in gpu blacklist.

So we can turn them off on older windows drivers between 2007 and 2009.

BUG=169938
TEST=content_unittests
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177239

[Zhenyao Mo, 2013-01-15 21:13:45]

vangelis: please review

[Zhenyao Mo, 2013-01-15 21:20:10]

estade: chrome/browser/ui/webui owner
joi: content/public owner
nduca: chrome/browser/resources/gpu_internals owner
apatrick: content/browser/gpu owner

[Evan Stade, 2013-01-15 21:39:07]

webui lgtm

[Jói, 2013-01-15 22:25:23]

LGTM for content/public.

[nduca, 2013-01-16 02:47:42]

lgtm

[vangelis, 2013-01-16 08:00:05]

https://codereview.chromium.org/11930003/diff/11002/chrome/browser/ui/webui/g...
File chrome/browser/ui/webui/gpu_internals_ui.cc (right):

https://codereview.chromium.org/11930003/diff/11002/chrome/browser/ui/webui/g...
chrome/browser/ui/webui/gpu_internals_ui.cc:326: (flags &
content::GPU_FEATURE_TYPE_FORCE_COMPOSITING_MODE) == 0,
I'm not sure I understand this part here. What would the message be if FCM is
disabled via the blacklist?  What would it be if FCM is on?

https://codereview.chromium.org/11930003/diff/11002/content/browser/gpu/compo...
File content/browser/gpu/compositor_util.cc (right):

https://codereview.chromium.org/11930003/diff/11002/content/browser/gpu/compo...
content/browser/gpu/compositor_util.cc:55: return false;
You'll need to check the blacklist entry here as well as if FCM is blacklisted
we should not be enabling threaded compositing.

https://codereview.chromium.org/11930003/diff/11002/content/browser/gpu/softw...
File content/browser/gpu/software_rendering_list.json (right):

https://codereview.chromium.org/11930003/diff/11002/content/browser/gpu/softw...
content/browser/gpu/software_rendering_list.json:950: "type": "linux"
ooops!  This should change back to mac!

[Zhenyao Mo, 2013-01-16 15:34:55]

https://codereview.chromium.org/11930003/diff/11002/chrome/browser/ui/webui/g...
File chrome/browser/ui/webui/gpu_internals_ui.cc (right):

https://codereview.chromium.org/11930003/diff/11002/chrome/browser/ui/webui/g...
chrome/browser/ui/webui/gpu_internals_ui.cc:326: (flags &
content::GPU_FEATURE_TYPE_FORCE_COMPOSITING_MODE) == 0,
On 2013/01/16 08:00:06, vangelis wrote:
> I'm not sure I understand this part here. What would the message be if FCM is
> disabled via the blacklist?  What would it be if FCM is on? 

If FCM is disabled via a blacklist entry, that entry will have a message to
display in about:gpu, so the message below shouldn't be triggered.

https://codereview.chromium.org/11930003/diff/11002/content/browser/gpu/compo...
File content/browser/gpu/compositor_util.cc (right):

https://codereview.chromium.org/11930003/diff/11002/content/browser/gpu/compo...
content/browser/gpu/compositor_util.cc:55: return false;
On 2013/01/16 08:00:06, vangelis wrote:
> You'll need to check the blacklist entry here as well as if FCM is blacklisted
> we should not be enabling threaded compositing.

Done.

https://codereview.chromium.org/11930003/diff/11002/content/browser/gpu/softw...
File content/browser/gpu/software_rendering_list.json (right):

https://codereview.chromium.org/11930003/diff/11002/content/browser/gpu/softw...
content/browser/gpu/software_rendering_list.json:950: "type": "linux"
On 2013/01/16 08:00:06, vangelis wrote:
> ooops!  This should change back to mac!

Holy cow.  Have no idea where this change comes from!

[Zhenyao Mo, 2013-01-16 15:42:48]

Revised.  Please take another look.

[vangelis, 2013-01-16 18:04:09]

Just two nits, otherwise LGTM

https://codereview.chromium.org/11930003/diff/17002/chrome/browser/ui/webui/g...
File chrome/browser/ui/webui/gpu_internals_ui.cc (right):

https://codereview.chromium.org/11930003/diff/17002/chrome/browser/ui/webui/g...
chrome/browser/ui/webui/gpu_internals_ui.cc:326: (flags &
content::GPU_FEATURE_TYPE_FORCE_COMPOSITING_MODE) == 0,
I think it would be more clear if the second part read:
!(flags & content::GPU_FEATURE_TYPE_FORCE_COMPOSITING_MODE)

https://codereview.chromium.org/11930003/diff/17002/content/browser/gpu/compo...
File content/browser/gpu/compositor_util.cc (right):

https://codereview.chromium.org/11930003/diff/17002/content/browser/gpu/compo...
content/browser/gpu/compositor_util.cc:57: GpuFeatureType blacklisted_features =
nit: Could you hoist that into a separate method in the unnamed namespace?

[Zhenyao Mo, 2013-01-16 20:53:36]

apatrick: can you stamp this CL (content/browser/gpu owner)

https://chromiumcodereview.appspot.com/11930003/diff/17002/chrome/browser/ui/...
File chrome/browser/ui/webui/gpu_internals_ui.cc (right):

https://chromiumcodereview.appspot.com/11930003/diff/17002/chrome/browser/ui/...
chrome/browser/ui/webui/gpu_internals_ui.cc:326: (flags &
content::GPU_FEATURE_TYPE_FORCE_COMPOSITING_MODE) == 0,
On 2013/01/16 18:04:09, vangelis wrote:
> I think it would be more clear if the second part read:
> !(flags & content::GPU_FEATURE_TYPE_FORCE_COMPOSITING_MODE)

Done.

https://chromiumcodereview.appspot.com/11930003/diff/17002/content/browser/gp...
File content/browser/gpu/compositor_util.cc (right):

https://chromiumcodereview.appspot.com/11930003/diff/17002/content/browser/gp...
content/browser/gpu/compositor_util.cc:57: GpuFeatureType blacklisted_features =
On 2013/01/16 18:04:09, vangelis wrote:
> nit: Could you hoist that into a separate method in the unnamed namespace? 

Done.

[Zhenyao Mo, 2013-01-16 21:09:33]

Added an entry to disable force_compositing_mode on Win Vista.

[Zhenyao Mo, 2013-01-16 21:12:13]

On 2013/01/16 21:09:33, Zhenyao Mo wrote:
> Added an entry to disable force_compositing_mode on Win Vista.

Never mind.  I deleted the last CL.  Per vangelis's sugegstion, we are
blacklisting vista in a separate CL.

[apatrick_chromium, 2013-01-16 21:18:57]

lgtm