Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: third_party/WebKit/Source/build/scripts/make_css_property_names.py

Issue 1192983003: CSS Custom Properties (Variables) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: s/FAST_ALLOCATED/FAST_MALLOC/ Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/build/scripts/make_css_property_names.py
diff --git a/third_party/WebKit/Source/build/scripts/make_css_property_names.py b/third_party/WebKit/Source/build/scripts/make_css_property_names.py
index e733c25dd494488483ed06386ab5c0d0eb0b6cd9..d08f755cc248a596386bcae3f7fc82ef93b1c390 100755
--- a/third_party/WebKit/Source/build/scripts/make_css_property_names.py
+++ b/third_party/WebKit/Source/build/scripts/make_css_property_names.py
@@ -28,6 +28,7 @@ namespace blink {
enum CSSPropertyID {
CSSPropertyInvalid = 0,
+ CSSPropertyVariable = 1,
%(property_enums)s
};
@@ -44,7 +45,7 @@ WTF::String getJSPropertyName(CSSPropertyID);
inline CSSPropertyID convertToCSSPropertyID(int value)
{
- ASSERT((value >= firstCSSProperty && value <= lastCSSProperty) || value == CSSPropertyInvalid);
+ ASSERT((value >= firstCSSProperty && value <= lastCSSProperty) || value == CSSPropertyInvalid || value == CSSPropertyVariable);
return static_cast<CSSPropertyID>(value);
}
@@ -119,7 +120,7 @@ const Property* findProperty(register const char* str, register unsigned int len
const char* getPropertyName(CSSPropertyID id)
{
- ASSERT(id >= firstCSSProperty && id <= lastUnresolvedCSSProperty);
+ ASSERT(id >= firstCSSProperty && id <= lastUnresolvedCSSProperty || id == CSSPropertyVariable);
Timothy Loh 2015/11/02 07:28:48 I don't think this assertion should be changed (if
int index = id - firstCSSProperty;
return propertyNameStringsPool + propertyNameStringsOffsets[index];
}

Powered by Google App Engine
This is Rietveld 408576698