third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.cpp - Issue 1192983003: CSS Custom Properties (Variables)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.cpp

Issue 1192983003: CSS Custom Properties (Variables) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove reftest.list :( Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "config.h"	5 #include "config.h"

6 #include "public/platform/WebMemoryDumpProvider.h"	6 #include "core/css/CSSCustomPropertyDeclaration.h"

7	7

8 namespace blink {	8 namespace blink {

9	9

10 WebMemoryDumpProvider::~WebMemoryDumpProvider()	10 DEFINE_TRACE_AFTER_DISPATCH(CSSCustomPropertyDeclaration)
	alancutter (OOO until 2018) 2015/10/28 07:31:20 Nit: This can just be inlined to avoid needing a c Nit: This can just be inlined to avoid needing a cpp file. leviw_travelin_and_unemployed 2015/10/30 21:41:16 I didn't spend a lot of time on this, but I verifi Show quoted text On 2015/10/28 at 07:31:20, alancutter wrote: > Nit: This can just be inlined to avoid needing a cpp file. I didn't spend a lot of time on this, but I verified it doesn't work the way you'd expect it to. There are no instances of DEFINE_TRACE_AFTER_DISPATCH in headers.
11 {	11 {

	12 visitor->trace(m_value);

	13 CSSValue::traceAfterDispatch(visitor);

12 }	14 }

13	15

14 } // namespace blink	16 } // namespace blink

OLD	NEW