CSS Custom Properties (Variables)

Source/core/css/ComputedStyleCSSValueMapping.cpp

 /*
  * Copyright (C) 2004 Zack Rusin <zack@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
  * Copyright (C) 2011 Sencha, Inc. All rights reserved.
  * Copyright (C) 2015 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
@@ skipping 2670 matching lines @@
             return cssValuePool().createValue(1, CSSPrimitiveValue::CSS_NUMBER);
         RefPtrWillBeRawPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
         list->append(cssValuePool().createValue(style.scale()->x(), CSSPrimitiveValue::CSS_NUMBER));
         if (style.scale()->y() == 1 && style.scale()->z() == 1)
             return list.release();
         list->append(cssValuePool().createValue(style.scale()->y(), CSSPrimitiveValue::CSS_NUMBER));
         if (style.scale()->z() != 1)
             list->append(cssValuePool().createValue(style.scale()->z(), CSSPrimitiveValue::CSS_NUMBER));
         return list.release();
     }
+    case CSSPropertyVariable:

[alancutter (OOO until 2018), 2015/07/14 06:12:57]

Can't say I'm comfortable with this naming, I have to think a bit extra every
time to make sure you're referring to a custom property and not a var(). I think
it would be clearer if custom properties didn't share the "variable" word.
In the future custom properties have applications beyond being referenced in
var() (CSS property polyfills and Houdini) so I think it's appropriate to not
tie the two together conceptually.

+        ASSERT_NOT_REACHED();
+        return nullptr;
     case CSSPropertyAll:
         return nullptr;
     default:
         break;
     }
     ASSERT_NOT_REACHED();
     return nullptr;
 }
 
 }