Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1192973004: Use optparse in js2c.py for python compatibility (Closed)

Created:
5 years, 6 months ago by bnoordhuis
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use optparse in js2c.py for python compatibility Without this change, V8 won't build on RHEL/CentOS 6 because the distro python is too old to know about the argparse module. Can this commit be cherry-picked to the 4.4 branch? It should apply cleanly. BUG= Committed: https://crrev.com/44bc918458481d60b08d5566f0f31a79e39b85d7 Cr-Commit-Position: refs/heads/master@{#29186}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M tools/js2c.py View 2 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
bnoordhuis
5 years, 6 months ago (2015-06-19 20:51:18 UTC) #2
domenic
The reason we switched to argparse is because optparse doesn't allow nargs="*" options (see https://github.com/v8/v8-git-mirror/commit/8a89a4a5ceeb58303cd9bc2d3e8d362742d59c96). ...
5 years, 6 months ago (2015-06-19 21:01:40 UTC) #3
noordhuis
For background: https://github.com/nodejs/io.js/pull/2022 I realize compatibility with older systems isn't a big issue for Google, ...
5 years, 6 months ago (2015-06-19 21:14:22 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192973004/1
5 years, 6 months ago (2015-06-22 07:09:30 UTC) #6
Michael Achenbach
lgtm +yang
5 years, 6 months ago (2015-06-22 07:10:08 UTC) #8
Yang
On 2015/06/22 07:10:08, Michael Achenbach wrote: > lgtm > > +yang lgtm.
5 years, 6 months ago (2015-06-22 07:23:31 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-22 07:30:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192973004/1
5 years, 6 months ago (2015-06-22 12:05:53 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-22 12:13:58 UTC) #14
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 12:14:07 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44bc918458481d60b08d5566f0f31a79e39b85d7
Cr-Commit-Position: refs/heads/master@{#29186}

Powered by Google App Engine
This is Rietveld 408576698