Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Unified Diff: components/password_manager/core/browser/password_store_default.cc

Issue 1192963002: Implement PasswordStoreProxyMac and SimplePasswordStoreMac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed the comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/password_store_default.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_store_default.cc
diff --git a/components/password_manager/core/browser/password_store_default.cc b/components/password_manager/core/browser/password_store_default.cc
index 40b070e32123b50c9d6ac9d4c9c33bc1c07a8cb8..4f305909444facab3c0168acabbcac563a7d1ede 100644
--- a/components/password_manager/core/browser/password_store_default.cc
+++ b/components/password_manager/core/browser/password_store_default.cc
@@ -24,8 +24,6 @@ PasswordStoreDefault::PasswordStoreDefault(
}
PasswordStoreDefault::~PasswordStoreDefault() {
- if (!GetBackgroundTaskRunner()->BelongsToCurrentThread())
- GetBackgroundTaskRunner()->DeleteSoon(FROM_HERE, login_db_.release());
}
bool PasswordStoreDefault::Init(
@@ -34,6 +32,11 @@ bool PasswordStoreDefault::Init(
return PasswordStore::Init(flare);
}
+void PasswordStoreDefault::Shutdown() {
+ PasswordStore::Shutdown();
+ ScheduleTask(base::Bind(&PasswordStoreDefault::ResetLoginDB, this));
+}
+
void PasswordStoreDefault::InitOnDBThread() {
DCHECK(GetBackgroundTaskRunner()->BelongsToCurrentThread());
DCHECK(login_db_);
@@ -169,4 +172,9 @@ scoped_ptr<InteractionsStats> PasswordStoreDefault::GetSiteStatsImpl(
: scoped_ptr<InteractionsStats>();
}
+void PasswordStoreDefault::ResetLoginDB() {
+ DCHECK(GetBackgroundTaskRunner()->BelongsToCurrentThread());
+ login_db_.reset();
+}
+
} // namespace password_manager
« no previous file with comments | « components/password_manager/core/browser/password_store_default.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698