Implement PasswordStoreProxyMac and SimplePasswordStoreMac.

components/password_manager/core/browser/password_store.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_STORE_H_
 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_STORE_H_
 
 #include "base/callback.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/observer_list_threadsafe.h"
 #include "base/single_thread_task_runner.h"
 #include "base/time/time.h"
 #include "components/password_manager/core/browser/password_store_change.h"
 #include "components/password_manager/core/browser/password_store_sync.h"
 #include "components/password_manager/core/browser/statistics_table.h"
 #include "sync/api/syncable_service.h"
 
 namespace autofill {
 struct PasswordForm;
 }
 
 namespace syncer {
 class SyncableService;
 }
 
+class PasswordStoreProxyMac;
+
 namespace password_manager {
 
 class AffiliatedMatchHelper;
 class PasswordStoreConsumer;
 class PasswordSyncableService;
 
 // Interface for storing form passwords in a platform-specific secure way.
 // The login request/manipulation API is not threadsafe and must be used
 // from the UI thread.
 // Implementations, however, should carry out most tasks asynchronously on a
@@ skipping 244 matching lines @@
   scoped_refptr<base::SingleThreadTaskRunner> main_thread_runner_;
 
   // TaskRunner for the DB thread. By default, this is the task runner used for
   // background tasks -- see |GetBackgroundTaskRunner|.
   scoped_refptr<base::SingleThreadTaskRunner> db_thread_runner_;
 
  private:
   FRIEND_TEST_ALL_PREFIXES(PasswordStoreTest, GetLoginImpl);
   FRIEND_TEST_ALL_PREFIXES(PasswordStoreTest,
                            UpdatePasswordsStoredForAffiliatedWebsites);
+  // TODO(vasilii): remove this together with PasswordStoreProxyMac.
+  friend class ::PasswordStoreProxyMac;

[vabr (Chromium), 2015/06/19 20:19:09]

One thing I did not understand -- why do you need to forward the protected calls
in the proxy? Is it because of tests? In production, nobody should call
protected methods on the proxy, and the proxy does not call them itself (all is
done in the backend). Would it work if you remove the friend declaration and
just forward the public methods in the proxy?

[vasilii, 2015/06/22 13:34:17]

Actually forwarding the protected calls is most important. There are things like
PasswordStore::observers_, PasswordStore::syncable_service_ etc. They should
live in PasswordStoreProxyMac then switching the backend is easier. In addition
the logic like notifying the observers just works. PasswordStoreMac becomes an
implementation detail of PasswordStoreProxyMac. Its public methods inherited
from PasswordStore are not needed anymore.

 
   // Schedule the given |func| to be run in the PasswordStore's own thread with
   // responses delivered to |consumer| on the current thread.
   void Schedule(void (PasswordStore::*func)(scoped_ptr<GetLoginsRequest>),
                 PasswordStoreConsumer* consumer);
 
   // Wrapper method called on the destination thread (DB for non-mac) that
   // invokes |task| and then calls back into the source thread to notify
   // observers that the password store may have been modified via
   // NotifyLoginsChanged(). Note that there is no guarantee that the called
@@ skipping 80 matching lines @@
   bool is_propagating_password_changes_to_web_credentials_enabled_;
 
   bool shutdown_called_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordStore);
 };
 
 }  // namespace password_manager
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_STORE_H_