Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 119293004: Set the gyp DEPTH variable as relative path. (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 11 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Set the gyp DEPTH variable as relative path. After r18439, it's an absolute variable which confuses gy LOG=n R=ulan@chromium.org BUG=none Committed: https://code.google.com/p/v8/source/detail?r=18440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/gyp_v8 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 11 months ago (2014-01-02 14:32:39 UTC) #1
ulan
lgtm
6 years, 11 months ago (2014-01-02 14:33:29 UTC) #2
jochen (gone - plz use gerrit)
6 years, 11 months ago (2014-01-02 14:35:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18440 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698