Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1192923002: Add support for multiple Workers in d8 (Closed)

Created:
5 years, 6 months ago by binji
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add d8 API for spawning function on a new thread (Third try) This API closely matches the Worker API. The differences: 1) The argument to the Worker constructor is a function to run, not a script. 2) Receiving a message from a worker is a synchronous API (as there is no event loop). The serialization done here is not robust as the real DOM implementation. For example, recursive data structures or otherwise duplicated objects are not allowed. BUG=chromium:497295 LOG=n Committed: https://crrev.com/001ee86e323a722fd4c0761d0b1a2c3a0c8f8e4b Cr-Commit-Position: refs/heads/master@{#29195}

Patch Set 1 : previous CL #

Patch Set 2 : multiple Workers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+896 lines, -7 lines) Patch
M src/d8.h View 1 6 chunks +122 lines, -0 lines 0 comments Download
M src/d8.cc View 1 11 chunks +643 lines, -7 lines 0 comments Download
A test/mjsunit/d8-worker.js View 1 1 chunk +131 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
binji
PTAL, this will fix the tree (at least my part of the failure :)
5 years, 6 months ago (2015-06-19 17:57:52 UTC) #2
binji
This new CL has the previous changes as patch #1, and the new changes with ...
5 years, 6 months ago (2015-06-19 18:43:12 UTC) #5
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-22 08:36:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192923002/40001
5 years, 6 months ago (2015-06-22 16:46:56 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 6 months ago (2015-06-22 17:12:35 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 17:12:50 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/001ee86e323a722fd4c0761d0b1a2c3a0c8f8e4b
Cr-Commit-Position: refs/heads/master@{#29195}

Powered by Google App Engine
This is Rietveld 408576698