Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: Source/modules/fetch/Response.h

Issue 1192913007: Change BodyStreamBuffer to be FetchDataConsumerHandle-based and enable backpressure in Fetch API (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Reflect comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/fetch/Response.h
diff --git a/Source/modules/fetch/Response.h b/Source/modules/fetch/Response.h
index 018bcc0d4c2235ab766ab539443a9edde4058bd1..305b122ab7b3b3287434bc6fb93a2a786082df59 100644
--- a/Source/modules/fetch/Response.h
+++ b/Source/modules/fetch/Response.h
@@ -19,6 +19,7 @@ namespace blink {
class Blob;
class BodyStreamBuffer;
+class DrainingBodyStreamBuffer;
class DOMArrayBuffer;
class ExceptionState;
class ResponseInit;
@@ -57,18 +58,20 @@ public:
// From Response.idl:
Response* clone(ExceptionState&);
- void populateWebServiceWorkerResponse(WebServiceWorkerResponse&);
+ // Does not call response.setBlobDataHandle().
+ void populateWebServiceWorkerResponse(WebServiceWorkerResponse& /* response */);
bool hasBody() const;
- PassRefPtr<BlobDataHandle> blobDataHandle() const override;
- BodyStreamBuffer* buffer() const override;
String mimeType() const override;
- PassRefPtr<BlobDataHandle> internalBlobDataHandle() const;
- BodyStreamBuffer* internalBuffer() const;
+ PassOwnPtr<DrainingBodyStreamBuffer> createInternalDrainingStream();
String internalMIMEType() const;
yhirano 2015/07/06 03:25:39 It might be good to place this function just after
hiroshige 2015/07/06 05:47:08 Done.
+ // Only for tests (null checks and identity checks).
+ void* bufferForTest() const;
+ void* internalBufferForTest() const;
+
DECLARE_VIRTUAL_TRACE();
private:

Powered by Google App Engine
This is Rietveld 408576698