Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: Source/modules/fetch/BodyStreamBufferTest.cpp

Issue 1192913007: Change BodyStreamBuffer to be FetchDataConsumerHandle-based and enable backpressure in Fetch API (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/fetch/BodyStreamBufferTest.cpp
diff --git a/Source/modules/fetch/BodyStreamBufferTest.cpp b/Source/modules/fetch/BodyStreamBufferTest.cpp
index eb017463b30358ac63ac68db8eaa211bbaafba84..f0319154454ba5f9571faf0802983d5cda5366c9 100644
--- a/Source/modules/fetch/BodyStreamBufferTest.cpp
+++ b/Source/modules/fetch/BodyStreamBufferTest.cpp
@@ -145,109 +145,6 @@ TEST(BodyStreamBufferTest, Observer)
EXPECT_EQ(0, observer2->errorCount());
}
-TEST(BodyStreamBufferTest, CreateBlob)
-{
- BodyStreamBuffer* buffer = new BodyStreamBuffer(new MockCanceller);
- BlobHandleCallback* callback1 = new BlobHandleCallback();
- BlobHandleCallback* callback2 = new BlobHandleCallback();
- EXPECT_TRUE(buffer->readAllAndCreateBlobHandle("text/html", callback1));
- EXPECT_FALSE(buffer->readAllAndCreateBlobHandle("text/html", callback2));
- buffer->write(DOMArrayBuffer::create("foobar", 6));
- EXPECT_FALSE(callback1->blobHandle());
- buffer->write(DOMArrayBuffer::create("piyo", 4));
- EXPECT_FALSE(callback1->blobHandle());
- buffer->close();
- EXPECT_TRUE(callback1->blobHandle());
- EXPECT_EQ("text/html", callback1->blobHandle()->type());
- EXPECT_FALSE(callback2->blobHandle());
- EXPECT_EQ(10u, callback1->blobHandle()->size());
- WebVector<WebBlobData::Item*> items;
- EXPECT_TRUE(Platform::current()->unitTestSupport()->getBlobItems(callback1->blobHandle()->uuid(), &items));
- EXPECT_EQ(2u, items.size());
- EXPECT_EQ(6u, items[0]->data.size());
- EXPECT_EQ(0, memcmp(items[0]->data.data(), "foobar", 6));
- EXPECT_EQ(4u, items[1]->data.size());
- EXPECT_EQ(0, memcmp(items[1]->data.data(), "piyo", 4));
- EXPECT_FALSE(callback1->exception());
- EXPECT_FALSE(callback2->exception());
-}
-
-TEST(BodyStreamBufferTest, CreateBlobAfterWrite)
-{
- BodyStreamBuffer* buffer = new BodyStreamBuffer(new MockCanceller);
- BlobHandleCallback* callback = new BlobHandleCallback();
- buffer->write(DOMArrayBuffer::create("foobar", 6));
- EXPECT_TRUE(buffer->readAllAndCreateBlobHandle("", callback));
- buffer->close();
- EXPECT_TRUE(callback->blobHandle());
- EXPECT_EQ(6u, callback->blobHandle()->size());
- WebVector<WebBlobData::Item*> items;
- EXPECT_TRUE(Platform::current()->unitTestSupport()->getBlobItems(callback->blobHandle()->uuid(), &items));
- EXPECT_EQ(1u, items.size());
- EXPECT_EQ(6u, items[0]->data.size());
- EXPECT_EQ(0, memcmp(items[0]->data.data(), "foobar", 6));
-}
-
-TEST(BodyStreamBufferTest, CreateBlobAfterClose)
-{
- BodyStreamBuffer* buffer = new BodyStreamBuffer(new MockCanceller);
- BlobHandleCallback* callback = new BlobHandleCallback();
- buffer->write(DOMArrayBuffer::create("foobar", 6));
- buffer->close();
- EXPECT_TRUE(buffer->readAllAndCreateBlobHandle("", callback));
- EXPECT_TRUE(callback->blobHandle());
- EXPECT_EQ(6u, callback->blobHandle()->size());
- WebVector<WebBlobData::Item*> items;
- EXPECT_TRUE(Platform::current()->unitTestSupport()->getBlobItems(callback->blobHandle()->uuid(), &items));
- EXPECT_EQ(1u, items.size());
- EXPECT_EQ(6u, items[0]->data.size());
- EXPECT_EQ(0, memcmp(items[0]->data.data(), "foobar", 6));
-}
-
-TEST(BodyStreamBufferTest, CreateBlobException)
-{
- BodyStreamBuffer* buffer = new BodyStreamBuffer(new MockCanceller);
- BlobHandleCallback* callback1 = new BlobHandleCallback();
- BlobHandleCallback* callback2 = new BlobHandleCallback();
- EXPECT_TRUE(buffer->readAllAndCreateBlobHandle("", callback1));
- EXPECT_FALSE(buffer->readAllAndCreateBlobHandle("", callback2));
- buffer->write(DOMArrayBuffer::create("foobar", 6));
- buffer->write(DOMArrayBuffer::create("piyo", 4));
- EXPECT_FALSE(buffer->hasError());
- buffer->error(DOMException::create(NetworkError, "Error Message"));
- EXPECT_TRUE(buffer->hasError());
- EXPECT_FALSE(callback1->blobHandle());
- EXPECT_FALSE(callback2->blobHandle());
- EXPECT_TRUE(callback1->exception());
- EXPECT_FALSE(callback2->exception());
- EXPECT_EQ("NetworkError", callback1->exception()->name());
- EXPECT_EQ("Error Message", callback1->exception()->message());
-}
-
-TEST(BodyStreamBufferTest, CreateBlobExceptionAfterWrite)
-{
- BodyStreamBuffer* buffer = new BodyStreamBuffer(new MockCanceller);
- BlobHandleCallback* callback = new BlobHandleCallback();
- buffer->write(DOMArrayBuffer::create("foobar", 6));
- EXPECT_TRUE(buffer->readAllAndCreateBlobHandle("", callback));
- buffer->error(DOMException::create(NetworkError, "Error Message"));
- EXPECT_TRUE(callback->exception());
- EXPECT_EQ("NetworkError", callback->exception()->name());
- EXPECT_EQ("Error Message", callback->exception()->message());
-}
-
-TEST(BodyStreamBufferTest, CreateBlobExceptionAfterError)
-{
- BodyStreamBuffer* buffer = new BodyStreamBuffer(new MockCanceller);
- BlobHandleCallback* callback = new BlobHandleCallback();
- buffer->write(DOMArrayBuffer::create("foobar", 6));
- buffer->error(DOMException::create(NetworkError, "Error Message"));
- EXPECT_TRUE(buffer->readAllAndCreateBlobHandle("", callback));
- EXPECT_TRUE(callback->exception());
- EXPECT_EQ("NetworkError", callback->exception()->name());
- EXPECT_EQ("Error Message", callback->exception()->message());
-}
-
TEST(BodyStreamBufferTest, Cancel)
{
auto canceller = new MockCanceller;

Powered by Google App Engine
This is Rietveld 408576698